fix incorrect TwicePerHour, 15,45 * * * * !== 'first and 30th minute'#44
Open
GDmac wants to merge 1 commit intoazza-bazoo:masterfrom
Open
fix incorrect TwicePerHour, 15,45 * * * * !== 'first and 30th minute'#44GDmac wants to merge 1 commit intoazza-bazoo:masterfrom
GDmac wants to merge 1 commit intoazza-bazoo:masterfrom
Conversation
TwicePerHour only checks if numbers.length === 2. It should check if the first part is on the hour. Test case: "15,45 * * * *"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TwicePerHour only checks if numbers.length === 2.
It should check if the first part is on the hour.
Test case: "15,45 * * * *"