Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s Calcit + JS toolchain and migrates from legacy Calcit manifests to the newer deps.cirru workflow, aligning local scripts and CI to build successfully with updated dependencies.
Changes:
- Migrated Calcit project metadata from
package.cirru/calcit.cirrutodeps.cirru, and refreshed generatedcompact.cirru. - Upgraded Yarn (to Berry) and Vite, including a new
.yarnrc.ymland updated lockfile format. - Updated GitHub Actions workflow to use Corepack + newer Calcit CLI and updated build commands.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Regenerated lockfile for Yarn Berry (v8 lock format) after dependency/toolchain upgrades. |
| package.json | Adds Yarn packageManager, introduces scripts, upgrades @calcit/procs and vite. |
| package.cirru | Removes legacy Calcit dependency manifest (replaced by deps.cirru). |
| deps.cirru | Adds new Calcit deps/config manifest with pinned dependency versions and calcit version. |
| compact.cirru | Updates generated compact output to new syntax/tooling (incl. async hint syntax). |
| calcit.cirru | Removes legacy Calcit full manifest output. |
| .yarnrc.yml | Configures Yarn Berry to use node-modules linker. |
| .gitignore | Ignores macOS .DS_Store and Yarn-generated gz artifacts. |
| .github/workflows/upload.yaml | Updates CI Node/Calcit setup, enables Corepack, and uses yarn install --immutable + new build commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| a $ {} | ||
| :href $ :url conf | ||
| :inner-text $ :url conf | ||
| :target "\"_blank" | ||
| :target |_blank | ||
| :style $ {} |
There was a problem hiding this comment.
Links opened with :target _blank should also set :rel to noopener noreferrer to prevent reverse-tabnabbing and to avoid giving the opened page access to window.opener. Add an appropriate :rel attribute to this anchor.
| a $ {} (:href |https://github.com/b-conf/chinese-tech-conf-schedule) (:inner-text "|Data source") (:target |_blank) (:class-name |minor-tip) | ||
| :style $ {} (:font-family ui/font-fancy) | ||
| =< 8 nil | ||
| a $ {} (:href "\"https://github.com/b-conf/conf-dates") (:inner-text "\"Fork") (:target "\"_blank") (:class-name "\"minor-tip") | ||
| a $ {} (:href |https://github.com/b-conf/conf-dates) (:inner-text |Fork) (:target |_blank) (:class-name |minor-tip) |
There was a problem hiding this comment.
These anchors use :target _blank but don't set :rel (e.g., noopener noreferrer). Please add :rel to both links to prevent reverse-tabnabbing and avoid exposing window.opener to the opened page.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Implemented in commit c6cd51e: added :rel |noopener noreferrer to all _blank anchors in compact.cirru (conference URL, data source, and fork links).
Screenshot:
Agent-Logs-Url: https://github.com/b-conf/conf-dates/sessions/7adbba46-fe3f-4edc-8658-97f324d80248 Co-authored-by: tiye <[email protected]>
Summary
Validation