[TASK] Add the possibility to set individual tag settings in sys_file_metadata - #25
Merged
Conversation
The ubuntu-latest GitHub Actions runner does not ship ImageMagick. AiWatermarkTest's brightness assertions silently compared an unwatermarked "flagged" image against "plain" (identical source photo) because AiWatermark::composite() fails without a "convert" binary and swallows the error - not sub-pixel flakiness, a missing CI dependency. Confirmed by reproducing the exact CI failure in an ubuntu:24.04 container without ImageMagick, then fixing it by installing the package.
achimfritz
approved these changes
Aug 24, 2026
| // pattern as AiMetaDataHandlerHook, but simpler: no review-workflow business rule, | ||
| // so whatever was submitted just wins, no AiLabelApi/nested-DataHandler needed. | ||
| #[Autoconfigure(public: true)] | ||
| final class AiWatermarkOverrideHandlerHook |
Contributor
There was a problem hiding this comment.
i think AiWatermark(Override)DataHandlerHook would be a better name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #19 / #18