Skip to content

Migrate to Helios#199

Merged
backspace merged 188 commits intomainfrom
helios
Dec 23, 2025
Merged

Migrate to Helios#199
backspace merged 188 commits intomainfrom
helios

Conversation

@backspace
Copy link
Copy Markdown
Owner

@backspace backspace commented Sep 22, 2025

This closes #184.

  • decide between toasts/alerts
  • cancellation dropdown not rendering/visible
  • move selectChoose inside page objects?
  • figure out missing icons (food, car?)
  • manual name entry with no matching ride doesn’t show
  • query parameters for ride filtering are broken (predates this PR but)
  • user calendar UI is weird
  • cannot open modals more than once?
  • cancellation dropdown not setting value
  • ride start/end blankness validation is swallowed
  • decide on text for non-match visitor name submission explanation
  • in “an error when an admin tries to create a commitment is displayed”, is commitment still displayed after save failure?
  • check everything on mobile
  • old style cleanup
  • look at Sass warnings etc
  • report row icon alignment
  • rides filter row alignment
  • statistics fields layout etc
  • add legacy domain
  • send email
  • survey session modals
    • register
    • login
    • forgot
    • reset
  • change loading animation colour

Frame/sidebar:

  • close automatically when tapping a link?
  • button in header needs scrolling

Mysterious console errors about decorators? But it works…
sometimes.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 22, 2025

Test Results

  1 files  ±0    1 suites  ±0   18s ⏱️ - 1m 10s
115 tests +9  114 ✅ +10  1 💤 ±0  0 ❌ ±0 
115 runs  +9  114 ✅ +11  1 💤 ±0  0 ❌  - 1 

Results for commit 534d94b. ± Comparison against base commit 9b806e5.

This pull request removes 106 and adds 115 tests. Note that renamed tests count towards both.
Chrome 142.0 ‑ Acceptance | authentication: authenticated users are redirected to the report form after logging out
Chrome 142.0 ‑ Acceptance | authentication: unauthenticated users are redirected to log in from authenticated routes
Chrome 142.0 ‑ Acceptance | authentication: unauthenticated users are redirected to the report form
Chrome 142.0 ‑ Acceptance | calendar: a failure to create a commitment makes it not display and shows an error
Chrome 142.0 ‑ Acceptance | calendar: a failure to create a commitment with a particular error shows the error
Chrome 142.0 ‑ Acceptance | calendar: a failure to delete a commitment keeps it displayed and shows an error
Chrome 142.0 ‑ Acceptance | calendar: an admin can create commitments
Chrome 142.0 ‑ Acceptance | calendar: an admin can delete commitments
Chrome 142.0 ‑ Acceptance | calendar: an admin can see the commitments with person names
Chrome 142.0 ‑ Acceptance | calendar: an error when an admin tries to create a commitment is displayed
…
Chrome 143.0 ‑ Acceptance | authentication: authenticated users are redirected to the report form after logging out
Chrome 143.0 ‑ Acceptance | authentication: unauthenticated users are redirected to log in from authenticated routes
Chrome 143.0 ‑ Acceptance | authentication: unauthenticated users are redirected to the report form
Chrome 143.0 ‑ Acceptance | calendar: a failure to create a commitment makes it not display and shows an error
Chrome 143.0 ‑ Acceptance | calendar: a failure to create a commitment with a particular error shows the error
Chrome 143.0 ‑ Acceptance | calendar: a failure to delete a commitment keeps it displayed and shows an error
Chrome 143.0 ‑ Acceptance | calendar: an admin can create commitments
Chrome 143.0 ‑ Acceptance | calendar: an admin can delete commitments
Chrome 143.0 ‑ Acceptance | calendar: an admin can see the commitments with person names
Chrome 143.0 ‑ Acceptance | calendar: an error when an admin tries to create a commitment is displayed
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
Chrome 142.0 ‑ Acceptance | users: shows who is present
Chrome 143.0 ‑ Acceptance | users: shows who is present

♻️ This comment has been updated with latest results.

# Conflicts:
#	package-lock.json
I couldn’t get the application to run anymore, maybe something
about pnpm…? ugh. But now I can replace components one at a time.
This makes the application render at least, very little to
show since all the Ember Paper components are empty, but
without this there was an `decorator is not a function` error
that would abort rendering.
it’s a start!
There’s a focus trap problem with the modal, which is a
major aspect of this, something to continue on.
It seems like it might have been working but 1.1.1 says
it needs Ember 4.16 which I’m not on.
This has rendering weirdness and I couldn’t figure out how
to get page objects to fit the structure 😞
This will need further cleanup.
whew! Another failing test but mostly working
@backspace backspace marked this pull request as ready for review December 23, 2025 19:48
@backspace backspace merged commit 9491024 into main Dec 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Helios?

1 participant