Skip to content

[WIP] POC PR for merging extra* fields #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+273 −118
Draft

[WIP] POC PR for merging extra* fields #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.6.1
version: 2.7.0
2 changes: 1 addition & 1 deletion charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 2.6.1](https://img.shields.io/badge/Version-2.6.1-informational?style=flat-square)
![Version: 2.7.0](https://img.shields.io/badge/Version-2.7.0-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying a Backstage application
Expand Down
8 changes: 8 additions & 0 deletions charts/backstage/templates/backstage-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,16 @@ spec:
key: {{ include "backstage.postgresql.databaseSecretKey" . }}
{{- end }}
{{- if .Values.backstage.extraEnvVars }}
{{- if (kindIs "map" .Values.backstage.extraEnvVars) }}
{{- /* If extraEnvVars is a dict, Helm will merge it automatically by key */ -}}
{{- range $_, $value := .Values.backstage.extraEnvVars }}
- {{- include "common.tplvalues.render" ( dict "value" $value "context" $) | nindent 14 }}
{{- end }}
{{- else if (kindIs "slice" .Values.backstage.extraEnvVars) }}
{{- /* If extraEnvVars is a list, keep current behavior (no merging) */ -}}
{{- include "common.tplvalues.render" ( dict "value" .Values.backstage.extraEnvVars "context" $) | nindent 12 }}
{{- end }}
{{- end }}
ports:
- name: backend
containerPort: {{ .Values.backstage.containerPorts.backend }}
Expand Down
Loading
Loading