chore: Removing default imagePullPolicy to honor Kubernetes defaults #287
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leanne Ahern <[email protected]>
Signed-off-by: Leanne Ahern <[email protected]>
rm3l
suggested changes
Oct 14, 2025
Signed-off-by: Leanne Ahern <[email protected]>
rm3l
suggested changes
Oct 14, 2025
Signed-off-by: Leanne Ahern <[email protected]>
rm3l
suggested changes
Oct 15, 2025
Signed-off-by: Leanne Ahern <[email protected]>
rm3l
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
LGTM. I think the failing tests should pass once #284 is merged.
OpinionatedHeron
changed the title
OpinionatedHeron
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Making image pullPolicy optional, so that default K8s behavior is honored. This change leaves the pullPolicy unset by default and allows Kubernetes to apply its tag-based default behavior ('Always' for latest, 'IfNotPresent' for other tags).
This change should improve startup times as it will not query the container image registry every time, if not necessary. Leaving the pullPolicy unset gives users the expected, standard behavior.
Additional Information
Based on documentation provided - https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.