announcements: Fix NewAnnouncementBanner & trigger notification on status update #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
Changed Packages
|
Signed-off-by: Hope Hadfield <[email protected]> Signed-off-by: Mattia <[email protected]>
….4 (backstage#5340) Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
… v2.23.4 (backstage#5368) Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
… status, navigate to root on edit complete Signed-off-by: Mattia <[email protected]>
matdtr
force-pushed
the
update-announcements
branch
from
82bcbe9 to
2463ab0
Compare
matdtr
requested review from
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
logonoff,
dzemanov,
AndrienkoAleksandr,
lholmquist and
PatAKnight
as code owners
matdtr
changed the title
gaelgoth
requested changes
Sep 22, 2025
| page?: number; | ||
| max?: number; | ||
| active?: boolean; | ||
| active?: string; |
There was a problem hiding this comment.
I would prefer to keep it as a boolean
Suggested change
| active?: string; | |
| active?: boolean; |
There was a problem hiding this comment.
Hi @gaelgoth, i do agree but on the GET path the backend receives the value as string that’s why the switch of type.
if kept as boolean it would fail as reported here #5235.
Let me know how you would like to address it, if revert the type or fix the tests.
PS.
Sorry maintainers not sure why all you got tagged in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixed handling of
activeprop in NewAnnouncementBannerExtended signal and notification on update when the annoucencement is activated
Updated
EditAnnoucementPageto navigate to root path as the announcement creation pageAll items reported in #5235
✔️ Checklist
Signed-off-byline in the message. (more info)