Hide create announcement button for unauthorized users #6035
+77
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the AnnouncementsPage to hide the 'New announcement' button when users lack create permission, rather than showing it in a disabled state. This provides a cleaner UI experience for users without the necessary permissions. Added tests to verify the button visibility based on permissions. Signed-off-by: sew9 <[email protected]>
backstage-service
added
the
workspace/announcements
Contributor
Changed Packages
|
gaelgoth
reviewed
Nov 17, 2025
Member
gaelgoth
left a comment
gaelgoth
left a comment
There was a problem hiding this comment.
Hi @Sew9, thanks for this!
Thinking out loud here; when setting up announcement permissions, having the button disabled could help confirm that the permissions are configured correctly. Maybe we could introduce a prop/config option that hides the button based on permissions if needed?
Would love to hear your thoughts on this as well, @kurtaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Changed the AnnouncementsPage to hide the 'New announcement' button when users lack create permission, rather than showing it in a disabled state. This provides a cleaner UI experience for users without the necessary permissions.
Added tests to verify the button visibility based on permissions.
after:
before:
✔️ Checklist
Signed-off-byline in the message. (more info)