fix tsc compilation errors in tsconfig.json

[nickboldt]

Hey, I just made a Pull Request!

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[awanlin]

Hi @nickboldt, same with this PR would it be possible to share why these changes are needed? We run yarn tsc:full (which runs tsc --skipLibCheck false --incremental false) as part of the CI and do not have any errors there so this seems somewhat unusual to me.

[nickboldt]

when I run the following from commit SHA dc6fb4379f7320d9230fcd635bc130cdd44fd500 of https://github.com/backstage/community-plugins:

yarn install; yarn tsc:full

I get these 2 typescript errors:

error TS2688: Cannot find type definition file for 'node'.
  The file is in the program because:
    Entry point of type library 'node' specified in compilerOptions

  tsconfig.json:18:15
    18     "types": ["node"]
                     ~~~~~~
    File is entry point of type library specified here.

error TS6053: File '/home/nboldt/RHDH/DH/4/4-rhdh-plugin-catalog/workspaces/analytics/node_modules/@backstage/cli/asset-types/asset-types.d.ts' not found.
  The file is in the program because:
    Part of 'files' list in tsconfig.json

  tsconfig.json:9:13
    9   "files": ["node_modules/@backstage/cli/asset-types/asset-types.d.ts"],
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    File is matched by 'files' list specified here.


Found 2 errors.

But yarn build:all is happy...

Building packages
Building apps
Building backends

[awanlin]

Hi @nickboldt, you closed your other somewhat related PR, do you still need this one?