fix(tui): rewrite word wrap to not strip whitespace #924
+130
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Wow, thank you for putting in the effort with the video explainer, much appreciated! I got annoyed by this today as well and wanted to fix it up, but now I don't have to spend time on this anymore. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with stripping surrounding whitespace in wrapped lines and aligns the wrapping behavior with modern text editors, while making the algorithm simpler.
The issue is that when the user hits Space at the start of a wrapped line, nothing seems to happen. But actually, the spaces are inserted under the hood. This behavior is confusing.
Here's the video showing the issue (audio):
Screen.Recording.2026-01-23.at.20.05.40.mp4
And here's a screenshot of a few text editors soft-wrapping the text at different points. Here, I chose to follow VS Code, Zed, and Edit and use their wrapping logic. I've included these examples in the tests.