Skip to content

Angiogenesis #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cainja wants to merge 56 commits into
base: main
Choose a base branch
from

temp edge fix

79bc465
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Angiogenesis #190

temp edge fix
79bc465
Select commit
Loading
Failed to load commit list.
GitHub Actions / checkstyle completed Jul 11, 2025 in 1s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (38)

src/arcade/patch/env/component/PatchComponentRemodel.java|34 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|251 col 9| Empty statement.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|378 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|652 col 9| Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getFraction' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getFraction' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|652 col 9| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|660 col 9| Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getTransport' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getTransport' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/patch/env/component/PatchComponentSitesGraph.java|660 col 9| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentDegrade.java|35 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java|24 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java|1243 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java|1282 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentGrowth.java|99 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentGrowth.java|407 col 5| Missing a Javadoc comment.
src/arcade/patch/env/component/PatchComponentGrowth.java|642 col 87| Expected @param tag for 'spanMap'.
src/arcade/patch/env/component/PatchComponentGrowth.java|845| Line is longer than 100 characters (found 103).
src/arcade/patch/env/component/PatchComponentGrowth.java|869| Line is longer than 100 characters (found 103).
src/arcade/patch/env/component/PatchComponentGrowth.java|1008| @return tag should be present and have description.
src/arcade/patch/env/component/PatchComponentGrowth.java|1017 col 27| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/module/PatchModuleMigration.java|62 col 23| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/module/PatchModuleProliferation.java|128 col 23| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/process/PatchProcessSensingSimple.java|17 col 5| Missing a Javadoc comment.
src/arcade/patch/sim/output/PatchOutputSerializer.java|158 col 15| Comment matches to-do format 'TODO:'.
src/arcade/core/gui/GUI.java|374 col 5| Class XMLFileFilter should be declared as final.
src/arcade/core/util/MatrixArray.java|14 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|53 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|53 col 55| Name 'i_nRows' must match pattern '^[a-z][a-zA-Z0-9]$'.
src/arcade/core/util/MatrixArray.java|53 col 68| Name 'i_Columns' must match pattern '^[a-z][a-zA-Z0-9]$'.
src/arcade/core/util/MatrixArray.java|112 col 5| Class 'MatrixArray' looks like designed for extension (can be subclassed), but the method 'multiply' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MatrixArray' final or making the method 'multiply' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/core/util/MatrixArray.java|112 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|126 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|127 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|127 col 5| 'VARIABLE_DEF' should be separated from previous line.
src/arcade/core/util/MatrixArray.java|128 col 5| Missing a Javadoc comment.
src/arcade/core/util/MatrixArray.java|128 col 5| 'VARIABLE_DEF' should be separated from previous line.
src/arcade/potts/vis/PottsVisualization.java|174 col 5| Method create3DDrawers length is 277 lines (max allowed is 150).
src/arcade/potts/sim/PottsSeries.java|215 col 15| Comment matches to-do format 'TODO:'.
test/arcade/potts/sim/Potts3DTest.java|1| File length is 2,371 lines (max allowed is 2,000).
test/arcade/potts/sim/Potts3DTest.java|211 col 18| ';' is followed by whitespace.

Filtered Findings (0)

Annotations

Check failure on line 34 in src/arcade/patch/env/component/PatchComponentRemodel.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentRemodel.java#L34 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentRemodel.java:34:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 251 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L251 <com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck> 

Empty statement.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:251:9: error: Empty statement. (com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck)

Check failure on line 378 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L378 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:378:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 652 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L652 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck> 

Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getFraction' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getFraction' static/final/abstract/empty, or adding allowed annotation for the method.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:652:9: error: Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getFraction' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getFraction' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)

Check failure on line 652 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L652 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:652:9: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 660 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L660 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck> 

Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getTransport' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getTransport' static/final/abstract/empty, or adding allowed annotation for the method.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:660:9: error: Class 'SiteEdge' looks like designed for extension (can be subclassed), but the method 'getTransport' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SiteEdge' final or making the method 'getTransport' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)

Check failure on line 660 in src/arcade/patch/env/component/PatchComponentSitesGraph.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraph.java#L660 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraph.java:660:9: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 35 in src/arcade/patch/env/component/PatchComponentDegrade.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentDegrade.java#L35 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentDegrade.java:35:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 24 in src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java#L24 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java:24:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 1243 in src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java#L1243 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java:1243:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 1282 in src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java#L1282 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentSitesGraphUtilities.java:1282:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 99 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L99 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:99:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)

Check failure on line 407 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L407 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:407:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 642 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L642 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck> 

Expected @param tag for 'spanMap'.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:642:87: error: Expected @param tag for 'spanMap'. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck)

Check failure on line 845 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L845 <LineLength> 

Line is longer than 100 characters (found 103).
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:845:0: error: Line is longer than 100 characters (found 103). (LineLength)

Check failure on line 869 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L869 <LineLength> 

Line is longer than 100 characters (found 103).
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:869:0: error: Line is longer than 100 characters (found 103). (LineLength)

Check failure on line 1008 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L1008 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck> 

@return tag should be present and have description.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:1008:0: error: @return tag should be present and have description. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck)

Check failure on line 1017 in src/arcade/patch/env/component/PatchComponentGrowth.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/env/component/PatchComponentGrowth.java#L1017 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck> 

Comment matches to-do format 'TODO:'.
Raw output 
/github/workspace/./src/arcade/patch/env/component/PatchComponentGrowth.java:1017:27: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 62 in src/arcade/patch/agent/module/PatchModuleMigration.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/agent/module/PatchModuleMigration.java#L62 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck> 

Comment matches to-do format 'TODO:'.
Raw output 
/github/workspace/./src/arcade/patch/agent/module/PatchModuleMigration.java:62:23: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 128 in src/arcade/patch/agent/module/PatchModuleProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/agent/module/PatchModuleProliferation.java#L128 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck> 

Comment matches to-do format 'TODO:'.
Raw output 
/github/workspace/./src/arcade/patch/agent/module/PatchModuleProliferation.java:128:23: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 17 in src/arcade/patch/agent/process/PatchProcessSensingSimple.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/agent/process/PatchProcessSensingSimple.java#L17 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/patch/agent/process/PatchProcessSensingSimple.java:17:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 158 in src/arcade/patch/sim/output/PatchOutputSerializer.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/patch/sim/output/PatchOutputSerializer.java#L158 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck> 

Comment matches to-do format 'TODO:'.
Raw output 
/github/workspace/./src/arcade/patch/sim/output/PatchOutputSerializer.java:158:15: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 374 in src/arcade/core/gui/GUI.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/core/gui/GUI.java#L374 <com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck> 

Class XMLFileFilter should be declared as final.
Raw output 
/github/workspace/./src/arcade/core/gui/GUI.java:374:5: error: Class XMLFileFilter should be declared as final. (com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck)

Check failure on line 14 in src/arcade/core/util/MatrixArray.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/core/util/MatrixArray.java#L14 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/core/util/MatrixArray.java:14:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 53 in src/arcade/core/util/MatrixArray.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/core/util/MatrixArray.java#L53 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> 

Missing a Javadoc comment.
Raw output 
/github/workspace/./src/arcade/core/util/MatrixArray.java:53:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
View more details on GitHub Actions