combinatorial circuits implementation + refactoring #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cainja
reviewed
Jun 19, 2025
Member
cainja
left a comment
cainja
left a comment
There was a problem hiding this comment.
More on the high level feedback:
- Not sure how I feel about there being 4 different classes here. Is there a way that we can combine them? I feel like this abstraction might be a little annoying to work with.
- I don't love the way that we're using super. I'm not sure it's more intuitive to specify super rather than not defining an overriding method at the same abstraction level.
- What's the benefit of the BindingEvent object? My impression is that it's implemented to track all binding events, but I think we are overcomplicating the irreversible behavior of synnotch? This is an incredibly expensive way to do this...
cainja
approved these changes
Jul 25, 2025
| getTissueAgents(allAgents, bag); | ||
| super.age++; | ||
|
|
||
| if (state != PatchEnums.State.APOPTOTIC && age > apoptosisAge) { |
Member
There was a problem hiding this comment.
I think referencing PatchEnums makes this somewhat hard to read
| super.unbind(); | ||
| this.activated = false; | ||
| } else { | ||
| // if CD8 cell is properly activated, it can be cytotoxic |
Member
There was a problem hiding this comment.
don't love that comment refers to CD8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to use this PR as a way to iterate on circuit implementation ideas. Any feedback would be greatly appreciated!
Description of major changes: