Skip to content

Add ability to determine offset in the frame of the Apical axis for PottsLocation2D #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jannetty merged 13 commits into from
Nov 17, 2025
Merged

Add ability to determine offset in the frame of the Apical axis for PottsLocation2D #198

Jannetty merged 13 commits into from
Nov 17, 2025

Conversation

@Jannetty
Copy link
Member

@Jannetty Jannetty commented Oct 20, 2025

Estimated time to review: medium

Summary of changes:

  • added function that projects a 2d location's voxels into a new frame such that the apical axis points up the location's new Y axis. Then performs "getOffset" functionality on voxels given specified offsets in (new) X and Y directions
  • Added tests for function

@Jannetty Jannetty requested review from a team, allison-li-1016, cainja, daniellevahdat, jacob-evarts, jessicasyu, kristaphommatha and pohaoc2 and removed request for a team October 20, 2025 18:43
@Jannetty Jannetty self-assigned this Oct 20, 2025
@Jannetty Jannetty added type: feature Improvement or additions to the code base package: potts Related to the potts implementation category: env Related to the env subpackages size: medium Estimated size of issue or PR is medium labels Oct 20, 2025
@Jannetty Jannetty marked this pull request as ready for review October 20, 2025 18:47
cainja
cainja approved these changes Oct 25, 2025
View reviewed changes
allison-li-1016
allison-li-1016 approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@allison-li-1016 allison-li-1016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Jannetty Jannetty merged commit cbfe37e into main Nov 17, 2025
6 checks passed
@Jannetty Jannetty deleted the feature/add-getoffsetinapicalframe-to-pottslocation2d branch November 17, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cainja cainja cainja approved these changes

@allison-li-1016 allison-li-1016 allison-li-1016 approved these changes

@jessicasyu jessicasyu Awaiting requested review from jessicasyu jessicasyu was automatically assigned from bagherilab/arcade-devs

@jacob-evarts jacob-evarts Awaiting requested review from jacob-evarts jacob-evarts was automatically assigned from bagherilab/arcade-devs

@kristaphommatha kristaphommatha Awaiting requested review from kristaphommatha kristaphommatha was automatically assigned from bagherilab/arcade-devs

@pohaoc2 pohaoc2 Awaiting requested review from pohaoc2 pohaoc2 was automatically assigned from bagherilab/arcade-devs

@daniellevahdat daniellevahdat Awaiting requested review from daniellevahdat daniellevahdat was automatically assigned from bagherilab/arcade-devs

Assignees

@Jannetty Jannetty

Labels

category: env Related to the env subpackages package: potts Related to the potts implementation size: medium Estimated size of issue or PR is medium type: feature Improvement or additions to the code base

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jannetty @cainja @allison-li-1016