Add fly cells and accompanying proliferation module #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

Jannetty wants to merge 57 commits into main from feature/add-flystemcells

Draft

Add fly cells and accompanying proliferation module #201

trying to update linter

GitHub Actions / checkstyle completed Nov 17, 2025 in 1s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (66)

test/arcade/potts/env/location/PottsLocation3DTest.java|305 col 9| Avoid nested blocks.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|65 col 11| Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]$'.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|642 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|682 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1160 col 7| Comment matches to-do format 'TODO:'.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1218 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1235 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java|17 col 9| 'VARIABLE_DEF' should be separated from previous line.
test/arcade/potts/sim/Potts3DTest.java|1| File length is 2,371 lines (max allowed is 2,000).
test/arcade/potts/sim/Potts3DTest.java|211 col 18| ';' is followed by whitespace.
src/arcade/patch/agent/module/PatchModuleProliferation.java|128 col 23| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/module/PatchModuleMigration.java|62 col 23| Comment matches to-do format 'TODO:'.
src/arcade/patch/sim/output/PatchOutputSerializer.java|158 col 15| Comment matches to-do format 'TODO:'.
src/arcade/core/gui/GUI.java|374 col 5| Class XMLFileFilter should be declared as final.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|33 col 1| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|68 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|91 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|93 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|95 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|138| Line is longer than 100 characters (found 101).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|193 col 37| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|195 col 54| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|202 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|202 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|203 col 21| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|248 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateGrowthRateBasedOnOtherNBs' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateGrowthRateBasedOnOtherNBs' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|248 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|257 col 16| Name 'Kn' must match pattern '^([a-z][a-zA-Z0-9]|)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|258 col 16| Name 'Npn' must match pattern '^([a-z][a-zA-Z0-9]*|)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|307 col 16| Name 'apical_axis' must match pattern '^([a-z][a-zA-Z0-9]|_)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|349 col 22| Expected @param tag for 'stemType'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|349 col 62| Expected @param tag for 'rotatedNormalVector'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|373 col 17| Conditional logic can be removed.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|390| Line is longer than 100 characters (found 105).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|394| Line is longer than 100 characters (found 113).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|396 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|455| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|483| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|553| Line is longer than 100 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|553| Line is longer than 120 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|566| Line is longer than 100 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|566| Line is longer than 120 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|602| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|659 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'getNBsInSimulation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'getNBsInSimulation' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|659 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|664 col 13| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|23 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|98 col 5| Class 'PottsModuleFlyGMCDifferentiation' looks like designed for extension (can be subclassed), but the method 'updateGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyGMCDifferentiation' final or making the method 'updateGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|98 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|115 col 21| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|118 col 21| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|7 col 8| Unused import - arcade.potts.agent.cell.PottsCellFlyNeuron.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|72 col 5| Class 'PottsModuleProliferationVolumeBasedDivision' looks like designed for extension (can be subclassed), but the method 'updateCellVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleProliferationVolumeBasedDivision' final or making the method 'updateCellVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|72 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|73 col 16| Name 'Ka' must match pattern '^([a-z][a-zA-Z0-9]|_)$'.
src/arcade/potts/agent/cell/PottsCellFactory.java|222| Line is longer than 100 characters (found 110).
src/arcade/potts/agent/cell/PottsCellFlyStem.java|14 col 1| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|62 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|94 col 5| Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'setApicalAxis' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'setApicalAxis' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|94 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|115| Line is longer than 100 characters (found 151).
src/arcade/potts/agent/cell/PottsCellFlyStem.java|115| Line is longer than 120 characters (found 151).
src/arcade/potts/agent/cell/PottsCellFlyStem.java|118 col 5| Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'make' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'make' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|118 col 5| Missing a Javadoc comment.
src/arcade/potts/sim/PottsSeries.java|215 col 15| Comment matches to-do format 'TODO:'.
src/arcade/potts/vis/PottsVisualization.java|174 col 5| Method create3DDrawers length is 277 lines (max allowed is 150).

Filtered Findings (0)

Annotations

Check failure on line 305 in test/arcade/potts/env/location/PottsLocation3DTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/env/location/PottsLocation3DTest.java#L305 <com.puppycrawl.tools.checkstyle.checks.blocks.AvoidNestedBlocksCheck>

Avoid nested blocks.

Raw output


            /github/workspace/./test/arcade/potts/env/location/PottsLocation3DTest.java:305:9: error: Avoid nested blocks. (com.puppycrawl.tools.checkstyle.checks.blocks.AvoidNestedBlocksCheck)

Check failure on line 65 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L65 <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck>

Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]*$'.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:65:11: error: Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]*$'. (com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck)

Check failure on line 642 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L642 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:642:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 682 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L682 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:682:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 1160 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1160 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1160:7: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 1218 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1218 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1218:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 1235 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1235 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1235:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 17 in test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java#L17 <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck>

'VARIABLE_DEF' should be separated from previous line.

Raw output


            /github/workspace/./test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java:17:9: error: 'VARIABLE_DEF' should be separated from previous line. (com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck)

Check failure on line 1 in test/arcade/potts/sim/Potts3DTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/sim/Potts3DTest.java#L1 <com.puppycrawl.tools.checkstyle.checks.sizes.FileLengthCheck>

File length is 2,371 lines (max allowed is 2,000).

Raw output


            /github/workspace/./test/arcade/potts/sim/Potts3DTest.java:1:0: error: File length is 2,371 lines (max allowed is 2,000). (com.puppycrawl.tools.checkstyle.checks.sizes.FileLengthCheck)

Check failure on line 211 in test/arcade/potts/sim/Potts3DTest.java

github-actions / checkstyle

[checkstyle] test/arcade/potts/sim/Potts3DTest.java#L211 <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyForIteratorPadCheck>

';' is followed by whitespace.

Raw output


            /github/workspace/./test/arcade/potts/sim/Potts3DTest.java:211:18: error: ';' is followed by whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyForIteratorPadCheck)

Check failure on line 128 in src/arcade/patch/agent/module/PatchModuleProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/patch/agent/module/PatchModuleProliferation.java#L128 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.

Raw output


            /github/workspace/./src/arcade/patch/agent/module/PatchModuleProliferation.java:128:23: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 62 in src/arcade/patch/agent/module/PatchModuleMigration.java

github-actions / checkstyle

[checkstyle] src/arcade/patch/agent/module/PatchModuleMigration.java#L62 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.

Raw output


            /github/workspace/./src/arcade/patch/agent/module/PatchModuleMigration.java:62:23: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 158 in src/arcade/patch/sim/output/PatchOutputSerializer.java

github-actions / checkstyle

[checkstyle] src/arcade/patch/sim/output/PatchOutputSerializer.java#L158 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.

Raw output


            /github/workspace/./src/arcade/patch/sim/output/PatchOutputSerializer.java:158:15: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 374 in src/arcade/core/gui/GUI.java

github-actions / checkstyle

[checkstyle] src/arcade/core/gui/GUI.java#L374 <com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck>

Class XMLFileFilter should be declared as final.

Raw output


            /github/workspace/./src/arcade/core/gui/GUI.java:374:5: error: Class XMLFileFilter should be declared as final. (com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck)

Check failure on line 33 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L33 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:33:1: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)

Check failure on line 68 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L68 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:68:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 91 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L91 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:91:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 93 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L93 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:93:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 95 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L95 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:95:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check warning on line 138 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L138 <LineLength>

Line is longer than 100 characters (found 101).

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:138:0: warning: Line is longer than 100 characters (found 101). (LineLength)

Check failure on line 193 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L193 <com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck>

Expression can be simplified.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:193:37: error: Expression can be simplified. (com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck)

Check failure on line 195 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L195 <com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck>

Expression can be simplified.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:195:54: error: Expression can be simplified. (com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck)

Check failure on line 202 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L202 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>

Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:202:5: error: Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)

Check failure on line 202 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L202 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck>

Missing a Javadoc comment.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:202:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 203 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L203 <com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck>

Expression can be simplified.

Raw output


            /github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:203:21: error: Expression can be simplified. (com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck)

View more details on GitHub Actions