Skip to content

Update CI linter #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pohaoc2 merged 11 commits into from
Nov 11, 2025
Merged

Update CI linter #205

pohaoc2 merged 11 commits into from
Nov 11, 2025

Conversation

@Jannetty
Copy link
Member

@Jannetty Jannetty commented Nov 10, 2025 •
edited
Loading

resolves #204

Estimated time to review: small

Summary of changes:

  • updated version of action-checkstyle from depricated v0.9.5 to most recent v3.0.0
  • made necessary parameter changes to action-checkstype
  • adjusted checks and suppressions so test-specific checks run on test files and src-specific tests run on src files
  • down graded TODO comments from throwing errors to throwing warnings
  • minor refactors to get code passing new checkstyle standards

@Jannetty Jannetty changed the title Patch/update lint ci Update CI linter Nov 10, 2025
@Jannetty Jannetty requested review from a team, allison-li-1016, cainja, daniellevahdat, jacob-evarts, jessicasyu, kristaphommatha and pohaoc2 and removed request for a team November 10, 2025 20:28
@Jannetty Jannetty self-assigned this Nov 10, 2025
@Jannetty Jannetty added priority: high Urgent problem that blocks the system until the issue is resolved type: bug Something isn't working as expected size: small Estimated size of issue or PR is small labels Nov 10, 2025
@Jannetty Jannetty linked an issue Nov 10, 2025 that may be closed by this pull request
Linter currently broken #204
Closed
@Jannetty Jannetty marked this pull request as ready for review November 10, 2025 20:29
kristaphommatha
kristaphommatha approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@kristaphommatha kristaphommatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M!

@pohaoc2 pohaoc2 merged commit 561231b into main Nov 11, 2025
6 checks passed
@pohaoc2 pohaoc2 deleted the patch/update-lint-CI branch November 11, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allison-li-1016 allison-li-1016 allison-li-1016 approved these changes

@kristaphommatha kristaphommatha kristaphommatha approved these changes

@cainja cainja Awaiting requested review from cainja cainja was automatically assigned from bagherilab/arcade-devs

@jessicasyu jessicasyu Awaiting requested review from jessicasyu jessicasyu was automatically assigned from bagherilab/arcade-devs

@jacob-evarts jacob-evarts Awaiting requested review from jacob-evarts jacob-evarts was automatically assigned from bagherilab/arcade-devs

@pohaoc2 pohaoc2 Awaiting requested review from pohaoc2 pohaoc2 was automatically assigned from bagherilab/arcade-devs

@daniellevahdat daniellevahdat Awaiting requested review from daniellevahdat daniellevahdat was automatically assigned from bagherilab/arcade-devs

Assignees

@Jannetty Jannetty

Labels

priority: high Urgent problem that blocks the system until the issue is resolved size: small Estimated size of issue or PR is small type: bug Something isn't working as expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linter currently broken

5 participants

@Jannetty @allison-li-1016 @kristaphommatha @pohaoc2