Skip to content

Conversation

@caijieming-ng
Copy link
Collaborator

modify master && tabletserver 's split interface

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加上DebugString吧,防止乱码

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些日志是必须的么?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kUnLoading2 kFrozen能加个注释不,分别代表什么状态

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kunloading2是原代码的状态,tablietio进行该卸载第二阶段,需要阻塞读写;kfrozen状态是卸载结束后tabletio进入的状态,表示该区间目前不操作;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进。。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else里面加个CHECK(false)吧。上面CHECK中的onsplit删掉

@caijieming-ng
Copy link
Collaborator Author

终于出现ts写坏meta表case了,感觉可以重启这货了

@bluebore
Copy link
Collaborator

两年了。。。还能起得来么

@caijieming-ng
Copy link
Collaborator Author

分裂流程的代码结构非常稳定,基本没有更新

@taocp
Copy link
Collaborator

taocp commented Jul 23, 2017

太有毅力了,简直我辈楷模呀,本渣自叹不如!

话说,感觉master修改meta表要“read-modify-wite”的事务才完全靠谱。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants