Skip to content

[Kernel] add topk_per_row to optimize the calculation of topk_indexes#166

Closed
fromck wants to merge 2 commits intobaidu:mainfrom
fromck:dev
Closed

[Kernel] add topk_per_row to optimize the calculation of topk_indexes#166
fromck wants to merge 2 commits intobaidu:mainfrom
fromck:dev

Conversation

@fromck
Copy link
Contributor

@fromck fromck commented Jan 30, 2026

PR Description

Add a topk_per_row operator to optimize the computation of topk_indices in the ds32 model. It requires the latest version of xspeedgate_ops.


Checklist (Required)

Before submitting this PR, please ensure that all the following items are completed:

  • All code changes pass the pre-commit checks.
  • Commits are signed off using git commit -s.
  • The PR title is properly classified (see below).

PR Type

Please prefix the PR title with one or more of the following labels to help reviewers quickly understand the nature of the change:

  • [Feature] – New features or enhancements (e.g. Attention, Communicator, Kernel, Worker, etc.)
  • [Bugfix] – Bug fixes
  • [CI/Build] – CI, build system, or infrastructure improvements
  • [Doc] – Documentation updates or fixes
  • [Misc] – Other changes that do not fit the above categories (use sparingly)

Note: If the PR spans multiple categories, include all relevant prefixes.


Detailed Checklist (Click to Expand)

Thank you for contributing to vLLM Kunlun! To help us maintain high code quality and streamline the review process, please ensure your PR meets the following requirements.

1. Code Quality

  • All linting and formatting checks pass (pre-commit).
  • The code is well-structured and sufficiently documented.
  • The change is designed with maintainability and readability in mind.

2. Testing

  • Relevant unit tests are added or updated.
  • Integration tests are included when applicable.
  • Existing tests continue to pass.

3. DCO Compliance

This project follows the Developer Certificate of Origin (DCO).

  • All commits include a Signed-off-by: line.
  • Use git commit -s to automatically add the sign-off.

4. Review Expectations

During the review process, maintainers may:

  • Request code refactoring or additional tests.
  • Ask for clarifications on design decisions.
  • Suggest performance, stability, or maintainability improvements.

We appreciate your patience and collaboration throughout the review process!

astrophel0 and others added 2 commits January 30, 2026 15:24
Signed-off-by: zhangzhenyi <zhangzhenyi@baidu.com>
Co-authored-by: zhangzhenyi <zhangzhenyi@baidu.com>
Signed-off-by: chengxiaokang <chengxiaokang@baidu.com>
@xyDong0223 xyDong0223 requested a review from baoqian426 January 30, 2026 11:02
@xyDong0223
Copy link
Collaborator

Hi,
Please check Code Style Check

@liwei109 liwei109 force-pushed the main branch 2 times, most recently from 2d1ed16 to 726cefb Compare February 1, 2026 05:54
@fromck fromck closed this Feb 2, 2026
@fromck fromck deleted the dev branch February 2, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants