Skip to content

Ensure nested updates actually updates the child records #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmarcelino wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure nested updates actually updates the child records #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2736657
Ensure associations update nested actually updates the child values
dmarcelino Apr 23, 2015
bb81f39
Merge branch 'master' into update_nested
dmarcelino Apr 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions interfaces/associations/belongsTo/update.nested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,13 @@ describe('Association Interface', function() {
////////////////////////////////////////////////////

it('should update association values', function(done) {

var customer = Customers[1].toObject();
customer.name = 'bar - updated';

var data = {
amount: 200,
a_customer: Customers[1]
a_customer: customer
};

Associations.Payment.update({ id: Payment.id }, data).exec(function(err, values) {
Expand All @@ -155,8 +158,9 @@ describe('Association Interface', function() {
.exec(function(err, model) {
assert(!err);

assert(model.amount === 200);
assert(model.a_customer.name === 'bar');
assert.equal(model.amount, 200);
assert.equal(model.a_customer.id, Customers[1].id);
assert.equal(model.a_customer.name, 'bar - updated');

done();
});
Expand Down
12 changes: 9 additions & 3 deletions interfaces/associations/hasMany/update.nested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,11 @@ describe('Association Interface', function() {

var data = {
name: '1:m update nested - updated',
payments: Payments.map(function(payment) { return payment.toObject(); })
payments: Payments.map(function(payment, idx) {
var res = payment.toObject();
res.amount = (idx + 1) * 10;
return res;
})
};

Associations.Customer.update({ id: Customer.id }, data).exec(function(err, values) {
Expand All @@ -183,8 +187,10 @@ describe('Association Interface', function() {
assert(model.payments.length === 2);

// Ensure association values were updated
assert(model.payments[0].amount === 1);
assert(model.payments[1].amount === 2);
assert.equal(model.payments[0].id, Payments[0].id);
assert.equal(model.payments[0].amount, 10);
assert.equal(model.payments[1].id, Payments[1].id);
assert.equal(model.payments[1].amount, 20);

done();
});
Expand Down
12 changes: 9 additions & 3 deletions interfaces/associations/manyToMany/update.nested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ describe('Association Interface', function() {

var taxiData = {
name: 'm:m update nested - updated',
taxis: Taxis.map(function(taxi) { return taxi.toObject(); })
taxis: Taxis.map(function(taxi, idx) {
var res = taxi.toObject();
res.medallion = (idx + 1) * 10;
return res;
})
};

Associations.Driver.update({ id: Driver.id }, taxiData).exec(function(err, values) {
Expand All @@ -181,8 +185,10 @@ describe('Association Interface', function() {
assert(model.taxis.length === 2);

// Ensure association values were updated
assert(model.taxis[0].medallion === 1);
assert(model.taxis[1].medallion === 2);
assert.equal(model.taxis[0].id, Taxis[0].id);
assert.equal(model.taxis[0].medallion, 10);
assert.equal(model.taxis[1].id, Taxis[1].id);
assert.equal(model.taxis[1].medallion, 20);

done();
});
Expand Down