Coerce env var values to empty string#23
Merged
Conversation
Contributor
Author
|
/rebase |
git-basejump
Bot
force-pushed
the
coerce-null-env-vars
branch
from
fcbaf4e to
a68e83c
Compare
pipex
reviewed
May 8, 2026
| environment: | ||
| EXPLICIT_VALUE: hello | ||
| EXPLICIT_EMPTY: "" | ||
| NULL_DICT_FORM: null |
There was a problem hiding this comment.
we should add an UNDEFINED_FORM: which is also accepted by compose. Weirdly docker-compose removes explicit fields defined with null but I saw that is not the same behavior of compose-go
Contributor
Author
There was a problem hiding this comment.
IMPLICIT_NULL_DICT_FORM: already covers the undefined case, but I renamed it to UNDEFINED_FORM: for clarity.
There was a problem hiding this comment.
I apologize, I don't know how I missed that 🤦🏼♂️
cywang117
force-pushed
the
coerce-null-env-vars
branch
from
a68e83c to
f21b4c8
Compare
Contributor
Author
|
/rebase |
Upstream API doesn't accept null/undefined for env var values, so we coerce to empty string just as balena-compose <=v7 (prior to compose-parser integration) did. Change-type: patch
git-basejump
Bot
force-pushed
the
coerce-null-env-vars
branch
from
f21b4c8 to
1aad1a2
Compare
pipex
approved these changes
May 11, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream API doesn't accept null/undefined for
env var values, so we coerce to empty string just
as balena-compose <=v7 (prior to compose-parser integration) did.
Change-type: patch