Skip to content

Clarify execFileSync vs execFile #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cywang117 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify execFileSync vs execFile #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/compose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execFile as execFileSync } from 'child_process';
import { execFile } from 'child_process';
import { promisify } from 'util';
import { randomUUID } from 'crypto';
import * as path from 'path';
Expand All @@ -23,7 +23,7 @@ import type {
ImageDescriptor,
} from './types';

const execFile = promisify(execFileSync);
const execFileAsync = promisify(execFile);

/**
* Parse one or more compose files using compose-go, and return a normalized composition object
Expand Down Expand Up @@ -59,7 +59,7 @@ export async function parse(
? 'balena-compose-parser.exe'
: 'balena-compose-parser';
const binaryPath = path.join(__dirname, '..', 'bin', binaryName);
const result = await execFile(binaryPath, args, {
const result = await execFileAsync(binaryPath, args, {
env: process.env,
}).catch((e) => {
// If exec error has stdout/stderr, handle them later; otherwise throw immediately
Expand Down
Loading