Convert extra_hosts separator from = to :#28
Merged
Conversation
pipex
reviewed
May 26, 2026
| } | ||
|
|
||
| // compose-go normalizes extra_hosts to `host=ip`, but our Engine expects `host:ip` | ||
| // even though latest Moby only supports `=`. Convert the separator back. |
There was a problem hiding this comment.
the issue is the supervisor that should convert = back to :, latest moby doesn't support = either https://github.com/moby/moby/blob/ad6b80a888d3248fba66ce149f1f072487f7697b/daemon/pkg/opts/hosts.go#L152
| path.relative(path.dirname(composeFilePath), build.context) || '.'; | ||
| } | ||
|
|
||
| // compose-go normalizes extra_hosts to `host=ip`, but our Engine expects `host:ip` |
There was a problem hiding this comment.
Not entirely sure this is needed on service.build, I suppose it is if extra_hosts is not processed by balena-compose either
cywang117
force-pushed
the
extra-hosts-separator
branch
from
80fb14e to
9f37db5
Compare
compose-go normalises extra_hosts to `=` separator, however neither Moby nor balenaEngine support =, both expect :. Change-type: patch
cywang117
force-pushed
the
extra-hosts-separator
branch
from
9f37db5 to
6789778
Compare
pipex
approved these changes
May 26, 2026
Contributor
Author
|
Relates to: balena-os/balena-supervisor#2524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compose-go normalises extra_hosts to
=separator,however neither Moby nor balenaEngine support =, both expect :.
Change-type: patch