Potential fix for code scanning alert no. 1: Prototype-polluting assignment#228
Draft
joshbwlng wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 1: Prototype-polluting assignment#228joshbwlng wants to merge 1 commit into
joshbwlng wants to merge 1 commit into
Conversation
joshbwlng
force-pushed
the
alert-autofix-1
branch
from
86c8ee8 to
c691a28
Compare
See: https://github.com/balena-io-modules/pinejs-client-js/security/code-scanning/1 Change-type: patch Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
joshbwlng
force-pushed
the
alert-autofix-1
branch
from
c691a28 to
d7a0253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/balena-io-modules/pinejs-client-js/security/code-scanning/1
General fix: validate computed property keys at runtime before indexing/writing, or use a structure immune to prototype keys (e.g.,
Map).Best minimal fix here: add a strict runtime allowlist check in
on(...)so only'data'and'error'are accepted, then proceed with existing logic unchanged.In
src/index.ts, insideon(...)(around lines 304–318), insert a guard beforethis.subscribers[name]access:name !== 'data' && name !== 'error', throw aTypeError.No new imports/dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.