Add support for orangepi-plus2e v2 by ajlennon · Pull Request #71 · balena-os/balena-allwinner

ajlennon · 2019-03-14T16:30:08Z

No description provided.

resin-jenkins · 2019-03-14T16:31:07Z

Can one of the admins verify this patch?

ajlennon · 2019-03-14T16:32:25Z

NB. The links I reference don't exist yet

e.g. https://docs.resin.io/orangepi-plus2e/nodejs/getting-started/#adding-your-first-device

floion · 2019-03-22T08:24:05Z

@resin-jenkins ok to test

floion · 2019-03-22T08:24:16Z

@resin-ci retest

floion · 2019-03-22T13:43:54Z

@resin-jenkins test this please

floion · 2019-03-22T13:54:14Z

Hi @ajlennon can you rebase the PR please and push it again?

To support WiFi for OrangePi-Plus2E Changelog-entry: Add meta-sunxi-contrib submodule layer Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Add a default dependency to bblayers to provide access to WiFi driver for OrangePi-Plus2E Changelog-entry: Add default dependency on meta-sunxi-contrib Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Provide needed bitbake meta data to build OrangePi-Plus2E output image. Changelog-entry: Add config. for OrangePi-Plus2E image build Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Provide WiFi driver specific connectivity configuration (rtl8189fs-mod) for OrangePi-Plus-2E board. Changelog-entry: Add connectivity config. for OrangePi-Plus2E WiFi Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Copy configuration for 2E based on -Plus2 (i.e. pl2303, wifi, hdmi) Changelog-entry: Configure linux kernel for OrangePi-Plus2E Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Configure internal storage device based on OrangePi-Plus2 i.e. 'emmc' is 'mmcblk2' Changelog-entry: Configure OrangePi-Plus2E internal storage Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Add OrangePi-Plus2E machine configuration for Bitbake. Changelog-entry: Add OrangePi-Plus2E machine configuration for Bitbake Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

This is a straight copy of the OrangePi-Plus2 image added as a placeholder (i.e. may need to be changed in future). Changelog-entry: Add OrangePi-Plus2E SVG image Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Add OrangePi-Plus2E COFFEE file for Belana.io barys build. Changelog-entry: Add OrangePi-Plus2E COFFEE file Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Add xradio driver for XR819 Wifi chipsets Changelog-entry: Add xradio out-of-tree kernel module

Add xradio firmware blobs for XR819 Changelog-entry: Add xradio firmware for XR819 Chipset

ajlennon · 2019-03-22T14:44:44Z

Hi @floion have done this

floion · 2019-03-23T08:58:05Z

 [submodule "layers/meta-rust"]
 	path = layers/meta-rust
 	url = https://github.com/meta-rust/meta-rust.git
+[submodule "layers/meta-sunxi-contrib"]


This submodule is not correctly added. The build server fails when fetching:

Command "git config --get submodule.layers/meta-sunxi-contrib.url" returned status code 1
Could not perform submodule update

How did you add the submodule in this PR? What are the commands you used?

floion · 2019-03-23T08:59:33Z

@@ -1,5 +1,6 @@
 CONNECTIVITY_FIRMWARES_append = " linux-firmware-ap6212 linux-firmware-brcm43362"
 CONNECTIVITY_MODULES_append_orangepi-plus2 = " rtl8189"
+CONNECTIVITY_MODULES_append_orangepi-plus2e = " rtl8189fs-mod"


Can you rephrase the commit log? "Connectivity config." doesn't describe what that package really is

floion · 2019-03-23T09:00:41Z

+#@NAME: Orange Pi Plus 2e
+#@DESCRIPTION: Machine configuration for the Orange Pi Plus2e, based on allwinner H3 CPU http://www.orangepi.org/
+
+require conf/machine/include/sun8i.inc


You should define instead a machine override like in: https://github.com/balena-os/balena-allwinner/blob/master/layers/meta-resin-allwinner/conf/machine/bananapi-m1-plus.conf#L5

floion · 2019-03-23T09:00:50Z

 # Flash to internal eMMC - kernel always enumerates emmc as mmcblk2
 INTERNAL_DEVICE_KERNEL_nanopi-neo-air = "mmcblk2"

+INTERNAL_DEVICE_KERNEL_orangepi-plus2e = "mmcblk2"


This can be removed if your machine conf file uses the machine override

floion · 2019-03-23T09:01:00Z

 "

 RESIN_CONFIGS_append_orangepi-plus2 = " hdmi"
+RESIN_CONFIGS_append_orangepi-plus2e = " hdmi"


This can be removed if your machine conf file uses the machine override

floion · 2019-03-23T09:01:08Z

 "

 RESIN_CONFIGS_append_orangepi-plus2 = " wifi"
+RESIN_CONFIGS_append_orangepi-plus2e = " wifi"


This can be removed if your machine conf file uses the machine override

floion · 2019-03-23T09:05:10Z

@@ -1,3 +1,21 @@
+#


Please redo the commit header.

For this commit, the header should be something like:

resin-image.inc:

So the header should always reference the file being changed, not the layer (layers/meta-resin-allwinner)
This change has to be done on all the commits

floion · 2019-03-23T09:05:59Z

+# Orange Pi Plus2e
+#
+
+IMAGE_FSTYPES_append_orangepi-plus2e = " resinos-img"


This can be removed if your machine conf file uses the machine override.

floion · 2019-03-23T09:06:18Z

+IMAGE_FSTYPES_append_orangepi-plus2e = " resinos-img"
+
+# Customize resinos-img
+RESIN_IMAGE_BOOTLOADER_orangepi-plus2e = "u-boot"


This can be removed if your machine conf file uses the machine override.

floion · 2019-03-23T09:06:58Z

+    uImage-sun8i-h3-orangepi-plus2e.dtb:/dtb/sun8i-h3-orangepi-plus2e.dtb \
+    u-boot-sunxi-with-spl.bin: \
+"
+IMAGE_CMD_resinos-img_append_orangepi-plus2e () {


This can be removed if your machine conf file uses the machine override.

floion · 2019-03-23T09:09:55Z

Hi @ajlennon I left comments for your PR.
Also, in addition to the comments there, I am leaving a general reminder here to redo the git logs for all the commits. See https://github.com/balena-os/balena-allwinner#pull-requests, at the beginning of the section it describes what the Yocto Contribution Guideline along with a short example.

floion · 2019-03-23T09:16:30Z

@resin-jenkins test this please

floion · 2019-03-23T09:28:02Z

@resin-jenkins test this please

floion · 2019-03-23T15:41:43Z

+	name: 'Orange Pi Plus2e'
+	arch: 'armv7hf'
+	state: 'experimental'
+        community: true


NIT: extra space here

ajlennon · 2019-03-23T16:03:52Z

I shall do my best. It'll be a few days before.i can find time to resolve these concerns

floion · 2019-09-25T04:10:19Z

Hi @ajlennon would you find some time to address the comments and redo this PR?

ajlennon · 2019-09-25T09:47:53Z

Mad busy at the minute @floion but I want to - will do my best!

ajlennon · 2019-10-28T18:18:03Z

Have asked one of the chaps here to take a look and see if he might be able to refactor for me!

MatthewCroughan · 2019-10-28T18:20:23Z

On my todo list.

ajlennon mentioned this pull request Mar 14, 2019

Add support for orangepi-plus2e #68

Closed

floion requested a review from a team March 22, 2019 13:42

ajlennon and others added 12 commits March 22, 2019 14:06

.gitmodules: Add meta-sunxi-contrib submodule layer

ff89c3c

To support WiFi for OrangePi-Plus2E Changelog-entry: Add meta-sunxi-contrib submodule layer Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Add dependency on meta-sunxi-contrib

58e3fe0

Add a default dependency to bblayers to provide access to WiFi driver for OrangePi-Plus2E Changelog-entry: Add default dependency on meta-sunxi-contrib Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Add config. for OrangePi-Plus2E image

ac36135

Provide needed bitbake meta data to build OrangePi-Plus2E output image. Changelog-entry: Add config. for OrangePi-Plus2E image build Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Configure linux kernel for OrangePi-Plus2E

0cf30e1

Copy configuration for 2E based on -Plus2 (i.e. pl2303, wifi, hdmi) Changelog-entry: Configure linux kernel for OrangePi-Plus2E Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Configure OrangePi-Plus2E internal storage

bd020b0

Configure internal storage device based on OrangePi-Plus2 i.e. 'emmc' is 'mmcblk2' Changelog-entry: Configure OrangePi-Plus2E internal storage Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Add OrangePi-Plus2E machine configuration

76464ad

Add OrangePi-Plus2E machine configuration for Bitbake. Changelog-entry: Add OrangePi-Plus2E machine configuration for Bitbake Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Add OrangePi-Plus2E SVG image

7cdd33a

This is a straight copy of the OrangePi-Plus2 image added as a placeholder (i.e. may need to be changed in future). Changelog-entry: Add OrangePi-Plus2E SVG image Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

layers/meta-resin-allwinner: Add OrangePi-Plus2E COFFEE file

c74a8ef

Add OrangePi-Plus2E COFFEE file for Belana.io barys build. Changelog-entry: Add OrangePi-Plus2E COFFEE file Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

xradio.bb: Add xradio driver

96eb0c2

Add xradio driver for XR819 Wifi chipsets Changelog-entry: Add xradio out-of-tree kernel module

xradio-firmware.bb: Add xradio firmware

c5a3c29

Add xradio firmware blobs for XR819 Changelog-entry: Add xradio firmware for XR819 Chipset

v2.27.0+rev5

2c89288

ajlennon force-pushed the ajl/orangepi-plus2e branch from 13e4a00 to 2c89288 Compare March 22, 2019 14:43

Merge branch 'master' into ajl/orangepi-plus2e

ec7808b

floion requested changes Mar 23, 2019

View reviewed changes

floion reviewed Mar 23, 2019

View reviewed changes

Uh oh!

Conversation

ajlennon commented Mar 14, 2019

Uh oh!

resin-jenkins commented Mar 14, 2019

Uh oh!

ajlennon commented Mar 14, 2019

Uh oh!

floion commented Mar 22, 2019

Uh oh!

floion commented Mar 22, 2019

Uh oh!

floion commented Mar 22, 2019

Uh oh!

floion commented Mar 22, 2019

Uh oh!

ajlennon commented Mar 22, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

floion commented Mar 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

floion commented Mar 23, 2019

Uh oh!

floion commented Mar 23, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajlennon commented Mar 23, 2019

Uh oh!

floion commented Sep 25, 2019

Uh oh!

ajlennon commented Sep 25, 2019

Uh oh!

ajlennon commented Oct 28, 2019

Uh oh!

MatthewCroughan commented Oct 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

floion commented Mar 23, 2019 •

edited

Loading