Report the supervisor core service to backend#2529
Merged
Conversation
pipex
force-pushed
the
supervisor-img-install
branch
from
adfd1f4 to
36fa6a7
Compare
pipex
changed the title
pipex
force-pushed
the
supervisor-img-install
branch
2 times, most recently
from
b129bb8 to
3791d96
Compare
Draft
pipex
force-pushed
the
supervisor-img-install
branch
2 times, most recently
from
7c7517c to
277e9d8
Compare
cywang117
reviewed
Jun 18, 2026
cywang117
left a comment
cywang117
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, let me know when ready for a final pass 👍🏼
| @@ -1,8 +1,9 @@ | |||
| export type SupervisorMetadata = { | |||
Contributor
There was a problem hiding this comment.
This type is no longer used after the deletion below so can be removed
Contributor
Author
There was a problem hiding this comment.
nice catch, forgot about that type
pipex
force-pushed
the
supervisor-img-install
branch
from
277e9d8 to
be24c71
Compare
The supervisor cannot update itself so its core service is removed from the target state before applying steps. However we do want the service to be reported so it shows up in the new `Supervisor services` table on the dashboard. Change-type: patch
This will allow it to show on the dashboard with that name in the Supervisor services table. Change-type: minor
pipex
force-pushed
the
supervisor-img-install
branch
from
ae5906f to
2c6627b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supervisor cannot update itself so its core service is removed from the target state before applying steps. However we do want the service to be reported so it shows up in the new
Supervisor servicestable on the dashboard.Change-type: patch