use ssh to send image instead of http to avoid timeouts#1087
Draft
rcooke-warwick wants to merge 6 commits into
Draft
use ssh to send image instead of http to avoid timeouts#1087rcooke-warwick wants to merge 6 commits into
rcooke-warwick wants to merge 6 commits into
Conversation
vipulgupta2048
left a comment
vipulgupta2048
left a comment
Contributor
There was a problem hiding this comment.
Flashing looks so much cleaner and it makes sense. Comments inline
| ) | ||
| } | ||
|
|
||
| // note: for the qemu case, we are assuming a shared volume between core and worker - this means that any image we want to flash must be in this volume - is it in all our cases? |
Contributor
There was a problem hiding this comment.
Who is this question for?
If you are asking me then yeah why not. The docker-compose will define the volumes once for QEMU and that should be the case everywhere no?
| async () => { | ||
| this.logger.log(`Sending image ${imagePath}`); | ||
| try{ | ||
| // arrives at worker as /data/os.img.gz |
Contributor
There was a problem hiding this comment.
Suggested change
| // arrives at worker as /data/os.img.gz | |
| // Sends image to worker at TARGET_PATH |
| ); | ||
|
|
||
| let TARGET_PATH = imagePath; | ||
| // if using remote worker i.e autokit/testbot, send the image over ssh |
Contributor
There was a problem hiding this comment.
Suggested change
| // if using remote worker i.e autokit/testbot, send the image over ssh | |
| // if autokit/testbot, send the image over ssh |
Clarity++, saying remote worker adds another shade of terminology
Comment on lines
+128
to
+150
| // Wrap sending of image in a retry - hopefully the --partial arguement in the rsync command means it will resume | ||
| // in the case of an error |
Contributor
There was a problem hiding this comment.
Suggested change
| // Wrap sending of image in a retry - hopefully the --partial arguement in the rsync command means it will resume | |
| // in the case of an error | |
| // Send image with rsync command, retry if error |
Comment on lines
+137
to
+159
| console.log(e); | ||
| throw new Error(`Rysnc error: ${e.message}`) |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log(e); | |
| throw new Error(`Rysnc error: ${e.message}`) | |
| throw new Error(`Rysnc error: ${e}`) |
| }, | ||
| ); | ||
|
|
||
| let TARGET_PATH = imagePath; |
Contributor
There was a problem hiding this comment.
Suggested change
| let TARGET_PATH = imagePath; | |
| let targetPath = imagePath; |
Can we change this everywhere to follow the same naming conventions.
rcooke-warwick
force-pushed
the
ryan/send-rsync
branch
from
0117693 to
0b88e1c
Compare
jakogut
reviewed
Jan 29, 2024
jakogut
left a comment
jakogut
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement. Re-inventing SSH over HTTP was always a bit of a head scratcher.
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
rcooke-warwick
force-pushed
the
ryan/send-rsync
branch
from
0b88e1c to
59c152c
Compare
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use with worker balena-os/leviathan-worker#93