Skip to content

e2e: probe supervisor /ping instead of /v1/healthy#1445

Merged
flowzone-app[bot] merged 1 commit into
masterfrom
kyle/e2e-supervisor-ping-probe
May 20, 2026
Merged

e2e: probe supervisor /ping instead of /v1/healthy#1445
flowzone-app[bot] merged 1 commit into
masterfrom
kyle/e2e-supervisor-ping-probe

Conversation

@klutchell

@klutchell klutchell commented May 20, 2026

Copy link
Copy Markdown
Contributor

balena-supervisor v17.6.26 fixed the connectivity healthcheck (balena-os/balena-supervisor@22e4d646) so /v1/healthy now requires the device to be actively reporting state to balena-cloud, which the local-mode DUT in this suite never does. /ping just checks that the supervisor process is up, which is what this test actually wants. meta-balena did the same swap in their cloud suite for the same reason (balena-os/meta-balena@6afa76bd); this also unblocks every leviathan-worker PR since 2026-04-30 (e.g. balena-os/leviathan-worker#185).

balena-supervisor v17.6.26 fixed an inverted boolean in the connectivity
healthcheck (balena-os/balena-supervisor@22e4d646), so /v1/healthy now
correctly returns 500 when the device isn't actively reporting state to
balena-cloud. The QEMU DUT in this suite is provisioned in local mode and
isn't registered to a fleet, so the supervisor never establishes that
report, deviceState.connected stays false, and the post-fix supervisor
honestly reports unhealthy. This has blocked every leviathan-worker PR
since 2026-04-30.

/ping is what this test actually wants: unauthenticated, no internal
checks, returns "OK" if the supervisor process is up. meta-balena did
the same thing in tests/suites/cloud/suite.js after hitting this on
2026-04-22 (balena-os/meta-balena@6afa76bd).

Change-type: patch
Signed-off-by: Kyle Harding <kyle@balena.io>
@klutchell klutchell force-pushed the kyle/e2e-supervisor-ping-probe branch from 4034447 to 8d1d5e8 Compare May 20, 2026 13:59
@klutchell klutchell requested a review from a team May 20, 2026 14:01

@mtoman mtoman left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexgg alexgg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flowzone-app flowzone-app Bot enabled auto-merge May 20, 2026 14:08
@klutchell klutchell temporarily deployed to balena-cloud.com May 20, 2026 14:08 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-cloud.com May 20, 2026 14:08 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-cloud.com May 20, 2026 14:08 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-cloud.com May 20, 2026 18:11 — with GitHub Actions Inactive
@flowzone-app flowzone-app Bot merged commit 5800614 into master May 20, 2026
348 of 353 checks passed
@flowzone-app flowzone-app Bot deleted the kyle/e2e-supervisor-ping-probe branch May 20, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants