e2e: probe supervisor /ping instead of /v1/healthy#1445
Merged
Conversation
balena-supervisor v17.6.26 fixed an inverted boolean in the connectivity healthcheck (balena-os/balena-supervisor@22e4d646), so /v1/healthy now correctly returns 500 when the device isn't actively reporting state to balena-cloud. The QEMU DUT in this suite is provisioned in local mode and isn't registered to a fleet, so the supervisor never establishes that report, deviceState.connected stays false, and the post-fix supervisor honestly reports unhealthy. This has blocked every leviathan-worker PR since 2026-04-30. /ping is what this test actually wants: unauthenticated, no internal checks, returns "OK" if the supervisor process is up. meta-balena did the same thing in tests/suites/cloud/suite.js after hitting this on 2026-04-22 (balena-os/meta-balena@6afa76bd). Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
4034447 to
8d1d5e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
balena-supervisor v17.6.26 fixed the connectivity healthcheck (balena-os/balena-supervisor@22e4d646) so
/v1/healthynow requires the device to be actively reporting state to balena-cloud, which the local-mode DUT in this suite never does./pingjust checks that the supervisor process is up, which is what this test actually wants. meta-balena did the same swap in their cloud suite for the same reason (balena-os/meta-balena@6afa76bd); this also unblocks every leviathan-worker PR since 2026-04-30 (e.g. balena-os/leviathan-worker#185).