major: Delete Core's helpers#977
Draft
vipulgupta2048 wants to merge 2 commits into
Draft
Conversation
Contributor
|
I would merge this only after balena-os/meta-balena#3091 is merged - as you probably already know but just posting it here for visibility |
Contributor
|
will we have to change this as well https://github.com/balena-os/leviathan#documentation-for-leviathan-helpers |
Contributor
Author
|
Done, good spot |
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
vipulgupta2048
force-pushed
the
vipul/delete-core
branch
from
0e82542 to
29685ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting Core's helpers to reduce dependencies in Core which is later scheduled to be deleted.
Core's helpers are now available at https://github.com/balena-os/test-helpers
Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com