Ryan/boot splash improvement - #2484
Merged
1 commit merged intoJan 28, 2022
Merged
Conversation
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
|
Can one of the admins verify this patch? |
Contributor
|
@balena-ci rebase |
Contributor
|
Looks good to me! |
ghost
force-pushed
the
ryan/boot-splash-improvement
branch
from
January 26, 2022 15:25
2ae2a37 to
2a14329
Compare
Contributor
|
@balena-ci rebase |
ghost
force-pushed
the
ryan/boot-splash-improvement
branch
from
January 27, 2022 13:18
2a14329 to
bd69430
Compare
Contributor
Author
|
I'm going to take the contract commit away from this, and just make it about making the boot splash test more consistent with more HDMI adapters I'll create a different PR with that change - as its an unrelated one |
rcooke-warwick
force-pushed
the
ryan/boot-splash-improvement
branch
from
January 27, 2022 15:10
bd69430 to
56fa744
Compare
Contributor
|
Looks good to me, you still have the draft label though |
Contributor
Author
|
@balena-ci rebase |
ghost
force-pushed
the
ryan/boot-splash-improvement
branch
from
January 28, 2022 10:08
56fa744 to
114b0f7
Compare
Contributor
Author
|
@resin-jenkins retest this please |
4 similar comments
Contributor
Author
|
@resin-jenkins retest this please |
Contributor
Author
|
@resin-jenkins retest this please |
Contributor
Author
|
@resin-jenkins retest this please |
Contributor
Author
|
@resin-jenkins retest this please |
Contributor
Author
|
@balena-ci I self-certify! |
ghost
approved these changes
Jan 28, 2022
Contributor
Author
|
@resin-jenkins retest this please |
ghost
deleted the
ryan/boot-splash-improvement
branch
January 28, 2022 16:26
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has 2 improvements to the boot-splash test
Contributor checklist
Change-typepresent on at least one commitSigned-off-byis presentReviewer Guidelines