Skip to content

Ryan/boot splash improvement - #2484

Merged
1 commit merged into
masterfrom
ryan/boot-splash-improvement
Jan 28, 2022
Merged

Ryan/boot splash improvement#2484
1 commit merged into
masterfrom
ryan/boot-splash-improvement

Conversation

@rcooke-warwick

Copy link
Copy Markdown
Contributor

This PR has 2 improvements to the boot-splash test

  1. relax the comparison between the reference image and the captured image - this will let us run this test with a greater range of hdmi capture devices
  2. Make the test execute only when the HDMI capture hardware is attached to the worker. This is reliant on these 2 PRs being merged: check testbot peripherals and populate contract (instead of using tags) leviathan#630 and patch: Use worker contracts in test suites #2478

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Change-type: patch
Signed-off-by: Ryan Cooke <ryan@balena.io>
@rcooke-warwick rcooke-warwick added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jan 25, 2022
@resin-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@klutchell

Copy link
Copy Markdown
Contributor

@balena-ci rebase

@klutchell

Copy link
Copy Markdown
Contributor

Looks good to me!

@ghost
ghost force-pushed the ryan/boot-splash-improvement branch from 2ae2a37 to 2a14329 Compare January 26, 2022 15:25
@klutchell

Copy link
Copy Markdown
Contributor

@balena-ci rebase

@ghost
ghost force-pushed the ryan/boot-splash-improvement branch from 2a14329 to bd69430 Compare January 27, 2022 13:18
@rcooke-warwick

rcooke-warwick commented Jan 27, 2022

Copy link
Copy Markdown
Contributor Author

I'm going to take the contract commit away from this, and just make it about making the boot splash test more consistent with more HDMI adapters

I'll create a different PR with that change - as its an unrelated one

@rcooke-warwick
rcooke-warwick force-pushed the ryan/boot-splash-improvement branch from bd69430 to 56fa744 Compare January 27, 2022 15:10
@klutchell

Copy link
Copy Markdown
Contributor

Looks good to me, you still have the draft label though

@rcooke-warwick rcooke-warwick removed the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jan 27, 2022
@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@balena-ci rebase

@ghost
ghost force-pushed the ryan/boot-splash-improvement branch from 56fa744 to 114b0f7 Compare January 28, 2022 10:08
@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

4 similar comments
@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@balena-ci I self-certify!

@rcooke-warwick

Copy link
Copy Markdown
Contributor Author

@resin-jenkins retest this please

@ghost
ghost merged commit ce81618 into master Jan 28, 2022
@ghost
ghost deleted the ryan/boot-splash-improvement branch January 28, 2022 16:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants