bug fix: mobynit: harden GOPROXY fallback during compile#3852
bug fix: mobynit: harden GOPROXY fallback during compile#3852billmcilhargey wants to merge 1 commit into
Conversation
… issues Change-type: minor
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
2 similar comments
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
Summary
https://goproxy.ioto the defaultGOPROXYchain before the existingdirectfallbackoe_runmakeonce duringdo_compileto absorb transient TLS stalls while fetching Go modulesIssue
Closes #3850
Why
mobynitcan fail duringdo_compilewhen Go module downloads hit a transient TLS handshake timeout againstproxy.golang.org.Before this change, the recipe used a single public proxy plus
direct, which left builds exposed to intermittent failures from that one upstream. This change makes module resolution more resilient by adding a second public Go proxy mirror and retrying the compile once when the failure is transient.Testing
origin/masterGOPROXY ??= "https://proxy.golang.org,https://goproxy.io,direct"do_compile()now exportsGOPROXYand runs:oe_runmake || oe_runmakeManual test case
mobyniton the affected branch baseline.do_compilefailures when module fetches time out againstproxy.golang.org.goproxy.ioor retry successfully instead of failing immediately on a transient TLS stall.Contributor checklist
Change-typepresent on at least one commitSigned-off-byis presentReviewer Guidelines