-
Notifications
You must be signed in to change notification settings - Fork 130
Allow multi kernel image builds #3893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexgg
wants to merge
4
commits into
master
Choose a base branch
from
alexgg/multi-kernel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−9
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexgg,
As you said this is only a part of the overall kernel and kernel module hostapp extension.
I see that there's a telling comment in meta-balena-raspberrypi that explain why we do this.
At first I thought that this was a re-edit of the config fragment mechanism of poky, so perhaps we should precise that poky's mechanism uses on SRC_URI and yours uses in FILESEXTRAPATHS. We could also explain why we do that. I suppose that it is so that we can have a kernel vendor not base on kernel-yocto and still have our own fragment added?
Also I'm wondering if we should merge this mechanism on its own or if we should wait for the rest of the feature? Is this whole change useful on its own?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ycardaillac
It's also explained in the commit log.
It is explained in the commit log.
The reasoning for the change is also in the commit log:
FILESEXTRAPATHS-reachable dir) without touching SRC_URI.
Basically, it adds a mechanism that extensions can use to customize a kernel. Neither Yocto's default or the balenaOS kernel class allow this.
And indeed it's generic so it works independently of the kernel-yocto class.
It's an independent mechanism to add kernel configuration so it stands on its own. There is no roadmap for extensions yet so there is no
rest of the featureto wait for. Without it, extensions would just work, but they will have no clean interface to overriding kernel and modules. But extensions that won't need this would just work fine.