Skip to content

Confirm before clearing recent projects - #11687

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/issue-8351-recent-clear-confirmation
Open

Confirm before clearing recent projects#11687
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/issue-8351-recent-clear-confirmation

Conversation

@BenJule

@BenJule BenJule commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a confirmation dialog before clearing all recent projects
  • make No the default choice to prevent accidental deletion
  • leave removal of individual recent projects unchanged

Testing

  • ran git diff --check
  • verified the Clear All confirmation control flow
  • verified that the dialog only appears for the empty-filename Clear All action
  • no local full build; the change is limited to the existing recent-project handler

Fixes #8351

@tonghao-bbl

Copy link
Copy Markdown
Contributor
image

Hi @BenJule can we use a native dialog for this?

@BenJule
BenJule force-pushed the fix/issue-8351-recent-clear-confirmation branch from eadfa40 to 767237d Compare August 10, 2026 08:07
@BenJule

BenJule commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @tonghao-bbl. Yes, I've updated the confirmation to use the native wxMessageDialog instead of Bambu Studio's custom MessageDialog wrapper.

No remains the default choice, so the existing protection against accidentally clearing the recent-project list is unchanged.

I also ran a targeted compile check of MainFrame.cpp using the existing Release build flags, and git diff --check passes.

Updated commit: 767237da8e

Could you please take another look? Thanks!

@tonghao-bbl

Copy link
Copy Markdown
Contributor

Thanks @tonghao-bbl. Yes, I've updated the confirmation to use the native wxMessageDialog instead of Bambu Studio's custom MessageDialog wrapper.

No remains the default choice, so the existing protection against accidentally clearing the recent-project list is unchanged.

I also ran a targeted compile check of MainFrame.cpp using the existing Release build flags, and git diff --check passes.

Updated commit: 767237da8e

Could you please take another look? Thanks!

Thanks for you quick action. Actually I mean we can use a native looking widget, anyway can you take a screen short of this message dialog so we can make this review faster?

@BenJule
BenJule force-pushed the fix/issue-8351-recent-clear-confirmation branch from 767237d to ab863b4 Compare August 10, 2026 12:05
BenJule added a commit to BenJule/BambuStudio that referenced this pull request Aug 10, 2026
BenJule added a commit to BenJule/BambuStudio that referenced this pull request Aug 10, 2026
@BenJule

BenJule commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @tonghao-bbl. I retested the final version with Jenkins build #31 (commit ab863b406d81).

The previous web confirmation has been removed, so Clear all now opens only the native-looking wxMessageDialog.

I verified both paths:

  • No is the default choice and leaves the recent-project list unchanged.
  • Yes clears the recent-project list as expected.

Before

The previous web confirmation:

Before - web confirmation dialog

After

The final native-looking confirmation dialog:

After - native wxMessageDialog

@tonghao-bbl

Copy link
Copy Markdown
Contributor

@zzsoccer214 Please take a look on Mac if the dialog looks good when available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad placement of button 'Clear All' in Recently Opened

2 participants