Skip to content

Use upstream GLEW v2.3.0 - #9315

Open
hadess wants to merge 1 commit into
bambulab:masterfrom
hadess:wip/hadess/upstream-glew
Open

Use upstream GLEW v2.3.0#9315
hadess wants to merge 1 commit into
bambulab:masterfrom
hadess:wip/hadess/upstream-glew

Conversation

@hadess

@hadess hadess commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@lanewei120
lanewei120 requested a review from MackBambu January 9, 2026 12:04
@hadess

hadess commented Jan 11, 2026

Copy link
Copy Markdown
Contributor Author

This works as expected in the Flatpak build:
flathub/com.bambulab.BambuStudio#86

The Windows and Mac build failures don't seem to be related.

@MackBambu

Copy link
Copy Markdown
Contributor

@hadess What benefits does upgrading to GLEW 2.3 bring? I checked the original Git history and it appears the version is 2.2.

It’s still unclear whether the build errors on macOS 15 are related, but the errors on Windows are clearly relevant. OpenCSG depends on GLEW, and it looks like there are some linking issues.

-- FindGLEW: GLEW_SHARED_LIBRARY_RELEASE: D:/a/BambuStudio/BambuStudio/deps/build/BambuStudio_dep/usr/local/lib/libglew32.lib
2026-01-08T11:25:42.8901328Z          -- FindGLEW: GLEW_STATIC_LIBRARY_RELEASE: GLEW_STATIC_LIBRARY_RELEASE-NOTFOUND
2026-01-08T11:25:42.8902234Z          -- FindGLEW: GLEW_SHARED_LIBRARY_DEBUG: GLEW_SHARED_LIBRARY_DEBUG-NOTFOUND
2026-01-08T11:25:42.8903058Z          -- FindGLEW: GLEW_STATIC_LIBRARY_DEBUG: GLEW_STATIC_LIBRARY_DEBUG-NOTFOUND
2026-01-08T11:25:42.8904176Z          -- FindGLEW: GLEW_SHARED_LIBRARY: D:/a/BambuStudio/BambuStudio/deps/build/BambuStudio_dep/usr/local/lib/libglew32.lib
2026-01-08T11:25:42.8905242Z          -- FindGLEW: GLEW_STATIC_LIBRARY: GLEW_STATIC_LIBRARY-NOTFOUND
2026-01-08T11:25:42.8905895Z          -- FindGLEW: GLEW_LIBRARIES: GLEW_STATIC_LIBRARY-NOTFOUND
2026-01-08T11:25:42.9288858Z          -- FindGLEW: GLEW_VERSION_MAJOR: 2
2026-01-08T11:25:42.9289410Z          -- FindGLEW: GLEW_VERSION_MINOR: 3
2026-01-08T11:25:42.9289871Z          -- FindGLEW: GLEW_VERSION_MICRO: 0
2026-01-08T11:25:42.9290285Z          -- FindGLEW: GLEW_VERSION: 2.3.0
2026-01-08T11:25:42.9297673Z          CMake Error at C:/Program Files/CMake/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
2026-01-08T11:25:42.9299547Z            Could NOT find GLEW (missing: GLEW_LIBRARIES) (found suitable version
2026-01-08T11:25:42.9300142Z            "2.3.0", minimum required is "1.13.0")
2026-01-08T11:25:42.9300572Z          Call Stack (most recent call first):
2026-01-08T11:25:42.9301210Z            C:/Program Files/CMake/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
2026-01-08T11:25:42.9301956Z            D:/a/BambuStudio/BambuStudio/cmake/modules/FindGLEW.cmake:213 (find_package_handle_standard_args)
2026-01-08T11:25:42.9302420Z            CMakeLists.txt:14 (find_package)
2026-01-08T11:25:42.9302644Z          
2026-01-08T11:25:42.9302786Z          
2026-01-08T11:25:42.9303258Z          -- Configuring incomplete, errors occurred!

@MackBambu MackBambu self-assigned this Jan 12, 2026
@hadess
hadess force-pushed the wip/hadess/upstream-glew branch from 664d3ec to 0789203 Compare June 6, 2026 19:42
@BambulabRobot
BambulabRobot requested review from guanyun-gudujian and lanewei120 and removed request for lanewei120 June 22, 2026 08:41
@hadess
hadess force-pushed the wip/hadess/upstream-glew branch 2 times, most recently from eebcdbb to 2bd9410 Compare August 8, 2026 14:21
@hadess

hadess commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@hadess What benefits does upgrading to GLEW 2.3 bring? I checked the original Git history and it appears the version is 2.2.

I removed the 2.3.0 update, I guess there's not much point in updating it if there are no relevant changes.

It’s still unclear whether the build errors on macOS 15 are related, but the errors on Windows are clearly relevant. OpenCSG depends on GLEW, and it looks like there are some linking issues.

I think that the copy-pasted version built static libs, whereas upstream creates shared libraries by default, let's see if this works.

@hadess
hadess force-pushed the wip/hadess/upstream-glew branch 2 times, most recently from 27c2559 to ace7ddc Compare August 9, 2026 09:12
Instead of our copy-paste version.
@hadess
hadess force-pushed the wip/hadess/upstream-glew branch from ace7ddc to 8da3cef Compare August 9, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants