Fixed typos #579
Closed
Fixed typos #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkitlabs
reviewed
Apr 22, 2025
| @@ -111,7 +111,7 @@ func (s *Signing) handleSigning(sid tss.SigningID) { | |||
| } | |||
|
|
|||
| // Compute own private nonce | |||
| privNonce, err := tss.ComputeOwnPrivNonce(privDE.PrivD, privDE.PrivE, assignedMember.BindingFactor) | |||
| privNonce, err := tss.ComputeOwnPrivNonce(provide.PrivD, provide.PrivE, assignedMember.BindingFactor) | |||
There was a problem hiding this comment.
keep them as is, (they are privateDE)
| @@ -3,7 +3,7 @@ Package params defines the simulation parameters in the band. | |||
|
|
|||
| It contains the default weights used for each transaction used on the module's | |||
| simulation. These weights define the chance for a transaction to be simulated at | |||
| any gived operation. | |||
| any given, gave operation. | |||
| @@ -2267,7 +2267,7 @@ type EVMValidatorsResponse struct { | |||
|
|
|||
| // BlockHeight is the latest block height | |||
| BlockHeight int64 `protobuf:"varint,1,opt,name=block_height,json=blockHeight,proto3" json:"block_height,omitempty"` | |||
| // Validators is list of validator's addresss and voting power | |||
| // Validators is list of validator's address and voting power | |||
| @@ -62,7 +62,7 @@ type QueryClient interface { | |||
| Reporters(ctx context.Context, in *QueryReportersRequest, opts ...grpc.CallOption) (*QueryReportersResponse, error) | |||
| // ActiveValidators queries all active oracle validators. | |||
| ActiveValidators(ctx context.Context, in *QueryActiveValidatorsRequest, opts ...grpc.CallOption) (*QueryActiveValidatorsResponse, error) | |||
| // Params queries parameters used for runnning bandchain network. | |||
| // Params queries parameters used for running bandchain network. | |||
There was a problem hiding this comment.
please fix it in proto/band/oracle/v1/query.proto and generate this file using command make proto-gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files updated:
/x/restake/README.md line: 277
/app/params/doc.go line: 6
/yoda/executor/multi.go line: 9
/api/band/oracle/v1/query_grpc.pb.go line: 65
/api/band/oracle/v1/query_grpc.pb.go line: 238
/api/band/base/node/v1/query.pulsar.go line: 2270
/cylinder/workers/signing/signing.go line: 104
/cylinder/workers/signing/signing.go line: 114
/cylinder/workers/signing/signing.go line: 114
/cylinder/workers/group/round2.go line: 132