[Feemarket] Add feemarket module #592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKSI
reviewed
Mar 24, 2025
testing/tx_helpers.go
Outdated
| @@ -146,6 +147,8 @@ func SignCheckDeliver( | |||
| require.Equal(t, 1, len(resBlock.TxResults)) | |||
| txResult := resBlock.TxResults[0] | |||
| finalizeSuccess := txResult.Code == 0 | |||
| fmt.Println("log", txResult.Log) | |||
warittornc
reviewed
Apr 8, 2025
nkitlabs
reviewed
Apr 9, 2025
| @@ -1,142 +0,0 @@ | |||
| package feechecker | |||
There was a problem hiding this comment.
also remove .proto and generated files (.pulsar, .pb) also check oracle merkle proof.
|
The feemarket module is not suitable for our laned mempool and its use is limited. So, I decided to pause this implementation for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)