Skip to content

chore: fix function name in comment #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

xixishidibei
Copy link
Contributor

@xixishidibei xixishidibei commented Apr 2, 2025

fix function name in comment

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

x/tss/keeper/keeper_signing_endblock.go:204

  • The comment still references 'pending process signing' while the function name is AddSigningExpiration. Consider updating it to 'adds a new signing expiration to the store' for better clarity.
// AddSigningExpiration adds a new pending process signing to the store.

x/oracle/keeper/signing.go:9

  • The comment mentions 'signing ID' instead of 'signing result', which can be confusing given the function and parameter names. Consider revising it to 'sets the key-value pair of the request ID to signing result in the store'.
// SetSigningResult sets the key-value pair of the request ID to signing ID in the store.

nkitlabs
nkitlabs previously approved these changes Apr 10, 2025
@nkitlabs nkitlabs self-requested a review April 10, 2025 04:09
@nkitlabs nkitlabs dismissed their stale review April 10, 2025 04:44

dismiss

Signed-off-by: xixishidibei <[email protected]>
@xixishidibei
Copy link
Contributor Author

Please review again.

@RogerKSI RogerKSI requested a review from nkitlabs April 11, 2025 04:10
@RogerKSI RogerKSI merged commit e320727 into bandprotocol:master Apr 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants