Skip to content

fix(ModelsCommand): use 'string' as realType for 'encrypted' casts #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pataar
Copy link
Contributor

@pataar pataar commented Apr 11, 2025

Summary

Laravel casts using 'encrypted' always result in a string. This is because Laravel encrypts the value directly without serialization. As a result, the output will never be anything other than a string.

Ref in HasAttributes.php:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@pataar pataar closed this Apr 11, 2025
@pataar pataar reopened this Apr 11, 2025
@pataar
Copy link
Contributor Author

pataar commented Apr 11, 2025

I tested this locally using the following test:

image

(email is encrypted)

@pataar pataar force-pushed the cast_encrypted_to_string branch from 1ab63d0 to 9d6bcc7 Compare April 11, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant