Don't use 'rescue' unecessarily (making url_for faster)#11
Open
jdelStrother wants to merge 3 commits intobartt:masterfrom
Open
Don't use 'rescue' unecessarily (making url_for faster)#11jdelStrother wants to merge 3 commits intobartt:masterfrom
jdelStrother wants to merge 3 commits intobartt:masterfrom
Conversation
added 3 commits
July 25, 2013 15:11
Throwing exceptions & catching them is relatively slow - we can make url_for measurably faster by avoiding that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - I was profiling a slow page with a lot of url_fors, and found the
non_ssl_hostmethod showing up in my profile. Throwing exceptions & catching them is relatively slow - how about the attached commit?If you want the benchmarks -