Skip to content

Commit

Permalink
boskos script uses/sets $PROJECT insted of $CLOUDSDK_CORE_PROJECT
Browse files Browse the repository at this point in the history
This is the only place $CLOUDSDK_CORE_PROJECT is referenced
in the testing flow. kube-up.sh and friends all use $PROJECT
to mean the GCP project. This should be standardized throughout
the codebase.
  • Loading branch information
michaelmdresser committed Jun 16, 2020
1 parent bf905db commit b1735f4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/boskos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ acquire_project() {

if project=$(echo "${boskos_response}" | jq -r '.name'); then
echo "Using GCP project: ${project}"
CLOUDSDK_CORE_PROJECT="${project}"
export CLOUDSDK_CORE_PROJECT
PROJECT="${project}"
export PROJECT
heartbeat_project_forever &
BOSKOS_HEARTBEAT_PID=$!
export BOSKOS_HEARTBEAT_PID
Expand All @@ -27,12 +27,12 @@ acquire_project() {

# release the project back to boskos
release_project() {
curl -X POST "http://boskos/release?name=${CLOUDSDK_CORE_PROJECT}&owner=${JOB_NAME}&dest=dirty"
curl -X POST "http://boskos/release?name=${PROJECT}&owner=${JOB_NAME}&dest=dirty"
}

# send a heartbeat to boskos for the project
heartbeat_project() {
curl -X POST "http://boskos/update?name=${CLOUDSDK_CORE_PROJECT}&state=busy&owner=${JOB_NAME}" > /dev/null 2>&1
curl -X POST "http://boskos/update?name=${PROJECT}&state=busy&owner=${JOB_NAME}" > /dev/null 2>&1
}

# heartbeat_project in an infinite loop
Expand Down

0 comments on commit b1735f4

Please sign in to comment.