Skip to content

Conversation

@jackchuma
Copy link
Contributor

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 17, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

@@ -0,0 +1,2 @@
OP_COMMIT=594bc933a38425f745b46399a3619bcdeb74965d
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant, but current OP contracts version commit that we are using on Sepolia

@@ -0,0 +1,2 @@
OP_COMMIT=594bc933a38425f745b46399a3619bcdeb74965d
BASE_CONTRACTS_COMMIT=98ec680a67c173d38aa52588c5dc0fbaa1c0561c
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Base contracts commit


.PHONY: deps
deps:
forge install --no-git github.com/base/bridge@755dfb9f6da7e79582a8ba04a4d64b180ca2eae8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Bridge commit

@@ -0,0 +1,13 @@
{
"salt": "0x928e88ac3b7e376abdda9d42289e3e39d878c78869402e3dc1fb002aaa0cc852",
"initialOwner": "0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incident multisig on Sepolia (3-of-14)

{
"salt": "0x928e88ac3b7e376abdda9d42289e3e39d878c78869402e3dc1fb002aaa0cc852",
"initialOwner": "0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f",
"partnerValidators": "0x0000000000000000000000000000000000000001",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will upgrade to use correct partnerValidators version when we have it

],
"baseSignatureThreshold": 2,
"partnerValidatorThreshold": 0,
"remoteBridge": "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add remote bridge pubkey when we have it

"baseSignatureThreshold": 2,
"partnerValidatorThreshold": 0,
"remoteBridge": "",
"guardians": ["0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incident multisig on Sepolia (3-of-14)

xenoliss
xenoliss previously approved these changes Oct 20, 2025
@cb-heimdall cb-heimdall dismissed xenoliss’s stale review October 23, 2025 21:39

Approved review 3357265000 from xenoliss is now dismissed due to new commit. Re-request for approval.

@jackchuma jackchuma merged commit 8ed7d1f into main Oct 23, 2025
5 checks passed
@jackchuma jackchuma deleted the jack/sepolia-deployment branch October 23, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants