bump node-reth commit reference to ad9d2be for latest flash-block metrics#458
Closed
bump node-reth commit reference to ad9d2be for latest flash-block metrics#458
Conversation
Collaborator
✅ Heimdall Review Status
|
Contributor
|
Refactoring in #460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mainbranch of base/node-reth moved forward 2025-05-07 (commitad9d2be3aeca48822c8a877470c0003696e8b4a5) adding Flash-block tracking and new metrics.Because
reth/Dockerfilestill pins the older hash3f3d846…, every fresh build aborts at the commit-verification step. This PR realigns the pinnedCOMMITvalue to the new HEAD so the image builds cleanly again. ([GitHub]1, [GitHub]2)Changes
No other logic or build flags were modified.
Rationale
ad9d2be.Testing
docker compose build --no-cachecompletes for bothexecutionandnodeservices.NODE_TYPE=base, confirmingbase-reth-nodebinary is present./metrics) exposes newflashblocks_in_blockgauge.