Skip to content

Dependency Updater: fix commit description formatting #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JenabaBa merged 9 commits into from
Aug 4, 2025
Merged

Dependency Updater: fix commit description formatting #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b8d5b80
fix commit description formatting
JenabaBa Aug 1, 2025
006a137
test new formatting
JenabaBa Aug 4, 2025
026a24e
retrigger workflow run
JenabaBa Aug 4, 2025
6f4adba
test if title was properly set
JenabaBa Aug 4, 2025
bd68407
test desc with quotes
JenabaBa Aug 4, 2025
640e31a
remove newline chars
JenabaBa Aug 4, 2025
16c8d7a
parenthesis fix
JenabaBa Aug 4, 2025
29492c2
add quotes to view commit desc
JenabaBa Aug 4, 2025
10624bf
remove newline
JenabaBa Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:
with:
title: ${{ steps.run_dependency_updater.outputs.TITLE }}
commit-message: ${{ steps.run_dependency_updater.outputs.TITLE }}
body: ${{ steps.run_dependency_updater.outputs.DESC }}
body: "${{ steps.run_dependency_updater.outputs.DESC }}"
branch: run-dependency-updater
delete-branch: true
7 changes: 3 additions & 4 deletions dependency_updater/dependency_updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,11 @@ func createCommitMessage(updatedDependencies []VersionUpdateInfo, repoPath strin
commitDescription += repo + " => " + tag + " (" + dependency.DiffUrl + ") "
repos = append(repos, repo)
}
commitDescription = strings.TrimSuffix(commitDescription, "\n")
commitDescription = strings.TrimSuffix(commitDescription, " ")
commitTitle += strings.Join(repos, ", ")

if githubAction {
commitDescription = "\"" + commitDescription + "\""
err := createGitMessageEnv(commitTitle, commitDescription, repoPath)
err := writeToGithubOutput(commitTitle, commitDescription, repoPath)
if err != nil {
return fmt.Errorf("error creating git commit message: %s", err)
}
Expand Down Expand Up @@ -340,7 +339,7 @@ func createVersionsEnv(repoPath string, dependencies Dependencies) error {
return nil
}

func createGitMessageEnv(title string, description string, repoPath string) error {
func writeToGithubOutput(title string, description string, repoPath string) error {
file := os.Getenv("GITHUB_OUTPUT")
f, err := os.OpenFile(file, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
if err != nil {
Expand Down