Skip to content

fixed typos and removed print #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JenabaBa merged 2 commits into from
Aug 13, 2025
Merged

fixed typos and removed print #521

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ac3cc6
fixed typos and removed print
letmehateu Aug 1, 2025
b871359
Update dependency_updater.go
letmehateu Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions dependency_updater/dependency_updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func main() {
Action: func(ctx context.Context, cmd *cli.Command) error {
err := updater(string(cmd.String("token")), string(cmd.String("repo")), cmd.Bool("commit"), cmd.Bool("github-action"))
if err != nil {
return fmt.Errorf("error running updater: %s", err)
return fmt.Errorf("running updater: %s", err)
}
return nil
},
Expand Down Expand Up @@ -153,7 +153,7 @@ func createCommitMessage(updatedDependencies []VersionUpdateInfo, repoPath strin
} else if !githubAction {
cmd := exec.Command("git", "commit", "-am", commitTitle, "-m", commitDescription)
if err := cmd.Run(); err != nil {
return fmt.Errorf("error running git commit -m: %s", err)
return fmt.Errorf("running git commit -m: %s", err)
Copy link
Collaborator

@JenabaBa JenabaBa Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for removing the error in front? ex. here

Copy link
Collaborator

@JenabaBa JenabaBa Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes it a bit unclear and sounds like "running git commit -m" is currently being run

Copy link
Contributor Author

@letmehateu letmehateu Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, yeah, that's my mistake. Sorry for that

makes it a bit unclear and sounds like "running git commit -m" is currently being run

Copy link
Collaborator

@JenabaBa JenabaBa Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np! other changes are fine

Copy link
Collaborator

@JenabaBa JenabaBa Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just
return fmt.Errorf("failed to run git commit -m: %s", err)

Copy link
Contributor Author

@letmehateu letmehateu Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed sir

}
}
return nil
Expand Down Expand Up @@ -293,9 +293,8 @@ func updateVersionTagAndCommit(
func writeToVersionsJson(repoPath string, dependencies Dependencies) error {
// formatting json
updatedJson, err := json.MarshalIndent(dependencies, "", " ")
print(dependencies["base_reth_node"].Branch)
if err != nil {
return fmt.Errorf("error Marshaling dependencies json: %s", err)
return fmt.Errorf("error marshaling dependencies json: %s", err)
}

e := os.WriteFile(repoPath+"/versions.json", updatedJson, 0644)
Expand Down Expand Up @@ -344,20 +343,20 @@ func createGitMessageEnv(title string, description string, repoPath string) erro
file := os.Getenv("GITHUB_OUTPUT")
f, err := os.OpenFile(file, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
if err != nil {
return fmt.Errorf("error failed to open GITHUB_OUTPUT file: %s", err)
return fmt.Errorf("failed to open GITHUB_OUTPUT file: %s", err)
}
defer f.Close()

titleToWrite := fmt.Sprintf("%s=%s\n", "TITLE", title)
_, err = f.WriteString(titleToWrite)
if err != nil {
return fmt.Errorf("error failed to write to GITHUB_OUTPUT file: %s", err)
return fmt.Errorf("failed to write to GITHUB_OUTPUT file: %s", err)
}

descToWrite := fmt.Sprintf("%s=%s\n", "DESC", description)
_, err = f.WriteString(descToWrite)
if err != nil {
return fmt.Errorf("error failed to write to GITHUB_OUTPUT file: %s", err)
return fmt.Errorf("failed to write to GITHUB_OUTPUT file: %s", err)
}

return nil
Expand Down