Skip to content

Dependency updater: remove hardcoded dependency key from debug line#522

Merged
JenabaBa merged 1 commit intobase:mainfrom
GarmashAlex:hpp2
Aug 6, 2025
Merged

Dependency updater: remove hardcoded dependency key from debug line#522
JenabaBa merged 1 commit intobase:mainfrom
GarmashAlex:hpp2

Conversation

@GarmashAlex
Copy link
Copy Markdown
Contributor

Removed the problematic debug line print(dependencies["base_reth_node"].Branch)
from the writeToVersionsJson function. This line contained a hardcoded key that
could cause a panic if the key doesn't exist in the dependencies map. The line
was not serving any functional purpose and was likely leftover debug code.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Aug 6, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Copy Markdown
Collaborator

Review Error for JenabaBa @ 2025-08-06 18:07:43 UTC
User failed mfa authentication, see go/mfa-help

@JenabaBa JenabaBa merged commit f988bd0 into base:main Aug 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants