-
Notifications
You must be signed in to change notification settings - Fork 833
Node provider docs for flashblocks #2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
@@ -14,9 +14,87 @@ Flashblocks enable up to 200 millisecond transaction confirmations on Base by le | |||
|
|||
Flashblocks is enabled for developers on Base Sepolia with full support for mainnet coming very soon. There are two ways you can integrate with Flashblocks data. You can either use the WebSocket API to stream real-time block updates, or use the RPC API to query the Flashblocks-aware RPC endpoint. | |||
|
|||
### RPC API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think app devs use RPC more so I moved it to the top
apps/base-docs/sidebar.ts
Outdated
@@ -1058,7 +1058,11 @@ export const sidebar: Sidebar = [ | |||
}, | |||
{ | |||
text: 'Flashblocks ↗', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the arrow since it isn't going offsite (so just Flashblocks
with no arrow after)
Sorry, this was an artifact from when I added the page, but we should remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey hey, thanks for putting this together! Just a few nits, left in-line 🙏
Approved review 2804860145 from wbnns is now dismissed due to new commit. Re-request for approval.
What changed? Why?
Adding node provider docs for setting up flashblocks-aware RPC reth nodes, and made some small tweak of the app integration guide, and library guide for
ethers
.Notes to reviewers
How has it been tested?
Have you tested the following pages?
BaseWeb
BaseDocs