Harden basenames metadata token validation #2821
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary - Validate basenames metadata tokenId to require a positive integer. - Return a clear 400 error for malformed tokenIds instead of throwing during BigInt conversion. ## Changes - Add numeric guard for tokenId in apps/web/app/(basenames)/api/basenames/metadata/[tokenId]/route.ts. ## Motivation Prevent unexpected 500s from invalid tokenIds and give clients actionable errors. ## Risk & Impact - Risk level: Low - Impact: Requests with non-numeric tokenIds now return 400; valid numeric tokenIds behave the same. ## Testing - [ ] Call GET /api/basenames/metadata/foo and expect 400. - [ ] Call with a numeric tokenId and confirm normal metadata response.
Collaborator
🟡 Heimdall Review Status
|
|
@Rufusemmanuel is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Motivation
Prevent unexpected 500s from invalid tokenIds and give clients actionable errors.
Risk & Impact
Testing