-
Notifications
You must be signed in to change notification settings - Fork 48
ActionTextAttachmentMarkNode #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
z-of-nz
wants to merge
65
commits into
basecamp:main
Choose a base branch
from
z-of-nz:comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n" to ALLOWED_HTML_TAGS - adds "style" to ALLOWED_HTML_ATTRIBUTES
…attachments programmatically
Render them as not-previeable attachments
Bumps [turbo-rails](https://github.com/hotwired/turbo-rails) from 2.0.16 to 2.0.20. - [Release notes](https://github.com/hotwired/turbo-rails/releases) - [Commits](hotwired/turbo-rails@v2.0.16...v2.0.20) --- updated-dependencies: - dependency-name: turbo-rails dependency-version: 2.0.20 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.35.0 to 4.38.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](SeleniumHQ/selenium@selenium-4.35.0...selenium-4.38.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-version: 4.38.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [puma](https://github.com/puma/puma) from 7.0.3 to 7.1.0. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/main/History.md) - [Commits](puma/puma@v7.0.3...v7.1.0) --- updated-dependencies: - dependency-name: puma dependency-version: 7.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Otherwise, when there are multiple Lexxy instances on the page, it always opens the first.
This will reposition the prompt on every change, so that the content is always correctly positioned regarding the cursor.
Lexical won´t handle these automatically
…n" to ALLOWED_HTML_TAGS - adds "style" to ALLOWED_HTML_ATTRIBUTES
…attachments programmatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned before, my task was to create a commenting feature in lexxy: My approach is to use Lexicals MarkNode.
Details:
ActionTextAttachmentMarkNode
@jorgemanrubia what is your take on my concept?
Dispatcher Commands for MarkNodes
The command for creating ActionTextAttachmentMarkNode(s) makes sure that all selections (could be several dom elements) are collected and marked by a selectionGroup - this ensures that the backend associates the multiple parts of the comment.