Updated Zellij themes with new specs#451
Conversation
|
Reverted in #456 with the error message this produced. |
The error seems to be due to the use of an old version of Zellij and therefore still expects the legacy format (ref). The new format is used since v0.42.0 and makes the legacy format incompatible with all functions (such as the text highlighter). So those who have not updated Zellij can use the legacy, while those who have installed Omakub since March or have updated it should use the new one. |
|
Hmm, I saw this with zellij 0.42.2. |
|
Hey - I hope it's alright to chime in. It would be cool to see Omakub use the new theme spec (it solves a lot of issues, including but not limited to the text selection contrast). I glanced briefly at the PR and don't see any issues with it. Would you maybe like to tell me what you're doing to produce this error so I can take a closer look? |
I have tried these specs in several installations (using both my fork and the original branch of this PR) and I have not encountered the error above. I can reopen the change, since I have it ready, and maybe I will try again to test it and find out the problem. |
|
Fix the errors found in #469 |
3 participants
This update is based on this issue which reports that text highlighting with the mouse no longer appears in the terminal.
Checking the Zellij documentation they changed the specs for the themes and those in the previous format are considered legacy although they are still supported.
I then proceeded with the alignment and then provided a migration script.
I found all the themes in the Zellij repository, instead for
rose-pineI relied on this repository and specifically on this PR, with the update already.