Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traefik, Wallabag, Olivetin #838

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

meonkeys
Copy link
Contributor

Description

This adds support for Traefik, Wallabag, and Olivetin cards. My motivation is so I can use this with my own services. This adds no new dependencies. Let me know if you'd rather this was in three separate PRs or whatever.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers. I did some testing, but not that much
  • I have made corresponding changes to the documentation (README.md). N/A
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@meonkeys meonkeys mentioned this pull request Nov 23, 2024
7 tasks
Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your work 🙏

Could you add an example of the api output here: https://github.com/bastienwirtz/homer/tree/main/dummy-data (more detail in the directory readme) ?

<template #content>
<p class="title is-4">{{ item.name }}</p>
<p class="subtitle is-6">
<template v-if="versionstring">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a check on item.subtitle to display the subtitle insted of the version if set ? (most service card integration works like that, I forgot to mention it on gitea)

Copy link
Contributor Author

@meonkeys meonkeys Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Done in 1864e1d . Except gitea/forgejo... I'll clean that up in a separate PR ( #839 )

@meonkeys
Copy link
Contributor Author

Awesome! Thanks for your work 🙏

Of course!

Could you add an example of the api output

Will do.

@bastienwirtz bastienwirtz merged commit f150c6c into bastienwirtz:main Dec 1, 2024
5 checks passed
@meonkeys meonkeys deleted the a-few-more-services branch December 12, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants