Fix cookie remove function (#111)

* add: pass domain to cookie remove function * 2.5.2
bazaarvoice · Aug 27, 2021 · 891c2ab · 891c2ab
1 parent bd0dd65
commit 891c2ab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/lib/cookie/index.js b/lib/cookie/index.js
@@ -62,9 +62,14 @@ function readCookie (name) {
  *
  * @param {String} name The cookie name.
  */
-function removeCookie (name) {
+function removeCookie (name, domain) {
   delete store[name];
-  createCookie(name, '', -1);
+  if (domain) {
+    createCookie(name, null, -1, domain);
+  }
+  else {
+    createCookie(name, '', -1);
+  }
 }
 
 module.exports = {
@@ -80,7 +85,7 @@ module.exports = {
     });
 
     cookieConsent.subscribe(name, 'disable', function () {
-      removeCookie(name);
+      removeCookie(name, domain);
     });
   },
   read: readCookie,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bv-ui-core",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "license": "Apache 2.0",
   "description": "Bazaarvoice UI-related JavaScript",
   "repository": {