Skip to content

Fixed Success Page on 2.4.5-p1 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAN1TAR1UM wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed Success Page on 2.4.5-p1 #101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac071ed
added type def
SAN1TAR1UM Oct 13, 2022
f077369
updated the other condition
SAN1TAR1UM Oct 13, 2022
0a48e71
fixed the third one
SAN1TAR1UM Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ViewModel/Pixel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,11 @@ public function getOrderDetails()
$this->orderDetails['tax'] = number_format((float)$order->getTaxAmount() ?? 0.0, 2, '.', '');
$this->orderDetails['shipping'] = number_format((float)$order->getShippingAmount() ?? 0.0, 2, '.', '');
if (!$this->taxConfig->discountTax()) {
$this->orderDetails['discount'] = number_format((float)abs($order->getDiscountAmount()) ?? 0.0, 2, '.', '');
$this->orderDetails['discount'] = number_format((float)abs((float)$order->getDiscountAmount()) ?? 0.0, 2, '.', '');
} else {
//when discount is applied to products "including tax" - extract tax compensation amount from "discount".
$this->orderDetails['discount'] = number_format(
(float)abs($order->getDiscountAmount()) - (float)abs($order->getDiscountTaxCompensationAmount()) ?? 0.0, 2, '.', ''
(float)abs((float)$order->getDiscountAmount()) - (float)abs((float)$order->getDiscountTaxCompensationAmount()) ?? 0.0, 2, '.', ''
);
}

Expand Down